Repository navigation
fix(captcha): follow-ups from #174 review - #177
Merged
Merged
Conversation
Add a test asserting that when select all fails, the paste is never pressed and the pasteboard is still restored, so staged text cannot land appended to the old contents. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The paste step now only runs when the preceding select-all succeeded, so a failed selection is reported instead of pasting beside the old text rather than replacing it. The outcome is computed once and passed through to restoration. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Adds node-backed tests that run the captcha scan script against a fake DOM to verify it scrolls to the first unanswered widget rather than the first visible one, treats a response field shared by two checkboxes as ambiguous, and marks a lone checkbox beside a filled field as answered. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
…d fields as unanswered The scan now scrolls to the first visible checkbox that is still unanswered rather than the first shown one, and a response field shared by several checkboxes no longer marks any of them as answered. The token lookup moved ahead of the scroll decision so it can be reused, and the doc comment was updated to match. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Joined the wrapped line in the SCAN_SCRIPT doc comment so the sentence reads continuously. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Replace the unchecked `as usize` cast with `usize::try_from` so the test helper cannot silently truncate values on platforms with narrower pointer widths. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00. Or wait 16 minutes for your next included review. View limit details
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #174, which merged with four review threads unanswered.
paste_through: when select-all fails on a SetValue field, skip paste, restore the clipboard, and return the select error (previously pasted anyway, appending to old text).holdsTokentreats a response field whose nearest ancestor holds more than one checkbox as not answered (ambiguous ownership).Regression tests were written first and failed before the fixes. The scan tests run the real script under node against a fake DOM (they return early if node is absent).
Refs #174