Repository navigation
Conversation
A callback-bound module's whole configuration was frozen for reinitialization, so any config change after load was refused until the host restarted. HostCallbackBinding::with_frozen_config_keys narrows the freeze to the declared callback-bearing keys (such as the callback destination); every other key may change on reinitialize. With no keys declared the whole blob stays frozen, as before. The stored fingerprint is still a SHA-256 hash, only key names are retained, and dropping a frozen key counts as a change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A callback-bound module's whole configuration is frozen for reinitialization, so any config change after load is refused with "scoped callback configuration is immutable" until the host restarts. That blocks tinyhumansai/openhuman#8725, where TinyComputer's browser, captcha and route settings change after load in security-module builds.
This adds HostCallbackBinding::with_frozen_config_keys, which narrows the freeze to the declared callback-bearing keys (such as the callback destination). Everything else in the config may change on reinitialize. With no keys declared the whole blob stays frozen, exactly as before. The stored fingerprint is still a SHA-256 hash, only key names are retained, and dropping a frozen key counts as a change.
Verified: new unit test for the scoped fingerprint, plus a cdylib test mirroring the existing immutability test (non-callback changes accepted, frozen-key change and removal refused). cargo fmt, clippy --all-targets --all-features -D warnings, and the module::host test module (105 passed) are clean. Full suite verdict is CI.
Summary by CodeRabbit