Skip to content

chore(vendor): move tinyinference to ae1f09d (local runtime native tools) - #612

Merged
senamakel merged 2 commits into
mainfrom
local-native-tools
Nov 12, 2026
Merged

senamakel merged 2 commits into
mainfrom
local-native-tools

Conversation

@senamakel

@senamakel senamakel commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Why

Teeny's builder agent runs glm-5.3-flash on Surplus through OpenHuman's local-openai runtime. The runtime always has native tool calls off, and with the JSON-in-tag text protocol Surplus turns the model's <tool_call> text into a call whose name is the whole JSON body, with arguments {}. Every builder job ends "abandoned: the builder never reported back".

Probes against Surplus (glm-5.3-flash, OpenAI-compatible), run on the Teeny box:

  1. No tools, model asked to emit JSON-in-tag: no tool_calls; the text stays text.
  2. tools=[shell], a normal ask: a clean native call, finish_reason=tool_calls, id call_7df8…, name shell, args {"command":"ls"}. Native tool calling works for this model on Surplus.
  3. tools sent plus "don't use native calls, write JSON-in-tag", non-stream: content came back verbatim, tool_calls null.
  4. Same as 3 with stream=true: only thinking chunks and no answer. Surplus attaches response_error: {format_error, content_validation: ["valid_think_chunk"], tool_calls_validation: [], extra_tags: ["only_thinking"]}. Surplus validates and rewrites output server-side, so the text protocol plus thinking is fragile there.

What

Moves vendor/tinyinference to ae1f09d (tinyhumansai/tinyinference#154), which adds build_local_runtime_chat_model_with_native_tools. The change is additive. cargo check -p tinyagents-harness --all-targets passes.

Depends on tinyhumansai/tinyinference#154. After it merges, move the gitlink to the merge commit.

Test

No harness code changes. The regression test is in tinyhumansai/tinyinference#154 (local_runtime_builder_can_opt_into_native_tools).

Summary by CodeRabbit

  • Chores
    • Updated a bundled component. No user-facing changes are identified in this update.

…ols)

Picks up build_local_runtime_chat_model_with_native_tools
(tinyhumansai/tinyinference#154) so OpenHuman can turn native tool calls on
for a local-openai endpoint that supports them.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Reviewed head: 6f9657687077223e347e08b7bee64b7cdf9d491a

Verdict: Ready for maintainer review · Priority: none
Coverage: File coverage is unavailable.
Pull request purpose (title): chore(vendor): move…

Diagnostics and supporting details

Full summary

Pull request purpose (title): chore(vendor): move tinyinference to ae1f09d (local runtime native tools). Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: No sensitive content in committed files. _The code index is behind this pull request (indexed at `51cfbde057c5`), so retrieved context may be out of date._

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: ladder/vectors-oai3
  • Spend: $0.000001
  • Tokens: 0 input · 0 output · 0 cached · 21 embedding
  • Updated: 2026-11-12T13:55:49Z
Head State Pass summary
232d2d6706c8 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-11-12T13:31:14Z)
6f9657687077 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-11-12T13:55:49Z)

tinysweeper 0.1.2

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T13:32:04.400071Z 232d2d6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 35 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c8ae75ff-165f-4a05-a08f-ac5b0816bbaa
Commits

Reviewing files that changed from the base of the PR and between 232d2d6 and 6f96576.

Files selected for processing: 1

  • vendor/tinyinference

No actionable comments were generated in the recent review.

Walkthrough

The vendor/tinyinference submodule reference changes from commit e8156d1d48a5fef0c787c6556adcdd8aff5ad266 to ae1f09dd3664796a61a35eaeebb090e8bbc7328e. The submodule contents are not included in the diff.

Changes: Tinyinference submodule update

Layer / File(s) Summary
Update submodule reference
vendor/tinyinference
The submodule pointer changes to commit ae1f09dd3664796a61a35eaeebb090e8bbc7328e.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: tinysweeper, m3ga-mind

Merge Risk: Minimal · previous review 232d2

This updates a vendored dependency pointer without changing OpenHuman code. No concrete merge-blocking risk is identified. Before merging, confirm that the upstream tinyinference change has landed and that the gitlink points at its merge commit.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the vendor gitlink for tinyinference moves to commit ae1f09d, which brings in native tool support for local runtime chat models. The PR objectives confirm this is the …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the vendor gitlink for tinyinference moves to commit ae1f09d, which brings in native tool support for local runtime chat models. The PR objectives confirm this is the purpose, since it enables native tool calls for supported local-openai endpoints. The 'chore(vendor)' prefix is conventional and the title is a single concise sentence, though it is a bit long at 73 characters.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the commit trail,
One pointer hops to a newer trail.
The vendor path now marks the place,
The unseen contents keep their space.
I nibble greens and watch it land.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a352b128-eadf-410e-9da0-2dea676ef12a
Commits

Reviewing files that changed from the base of the PR and between 6d1416d and 232d2d6.

Files selected for processing: 1

  • vendor/tinyinference

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

Diagnostics

Total spend: $0.0000

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Nov 12, 2026
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel merged commit 56e6aaa into main Nov 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant