Repository navigation
feat(browser): [browser] upstream_proxies routes chosen domains through an upstream proxy (TinyComputer v0.19.0) - #8743
Conversation
Update the vendored tinycomputer submodule to the latest upstream commit. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Adds a `[browser] upstream_proxies` config option that routes listed destination domains through an HTTP proxy, for sites that reject the machine's own address. Proxy URLs are kept out of logs and Debug output, and every dial they cause still passes through egress authorization. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Expose the browser upstream proxy type alongside BrowserConfig so downstream code can reference it through the tools config module without reaching into the browser submodule directly. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add tests asserting that upstream proxy entries parse from TOML and default to empty, that proxy credentials are stripped from config snapshots and Debug output, and that configured proxies are carried in the private egress section while the dial alias stays stable. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Re-exported BrowserUpstreamProxy at the schema module root and updated the tests to reference it there instead of the nested tools path, so callers can import the type without reaching into the tools submodule. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Adds a section explaining how to route chosen domains through an upstream HTTP proxy when sites reject datacenter addresses, covering domain matching, policy enforcement, credential handling and failure behaviour. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Document that TinyComputer requests a CONNECT tunnel to an address TinySecurity approved for the page's host, so the proxy resolves nothing, and that the Host header and TLS SNI pass through unchanged. The tinycomputer vendor submodule is bumped to the matching revision. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the vendored tinycomputer submodule to the latest upstream commit. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the pinned tinycomputer module record to version 0.19.0, refreshing the release URL and the archive names and SHA-256 checksums for every published platform asset. The vendor submodule is advanced to the matching revision so the bundled source stays in sync with the pinned release. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Bump the expected module version and the published artifact names and checksums for every target so the registry contract test tracks the 0.19.0 release. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the version of the tinycomputer crates in the lockfile from 0.18.0 to 0.19.0 to reflect the new release. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the locked tinycomputer-bus dependency from 0.18.0 to 0.19.0 in the app's Cargo.lock. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Pin the tinycomputer-bus dependency back to 0.18.0 in the app lockfile, reverting the earlier bump to 0.19.0. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Adds Ed25519 signing dependencies and base58 encoding to the app crate, and updates tinycomputer-bus to 0.19.0. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
There was a problem hiding this comment.
🟡 Changes recommended
Proxy configuration changes after module load trigger reinitialization that TinyBus rejects, causing calls to fail instead of preserving the existing routing until restart.
1 open issue
What changed in this PR
Adds domain-specific browser proxy configuration to OpenHuman, delegating routing to TinyComputer v0.19.0 while preserving browser egress policy checks.
Changes:
- Adds
[browser] upstream_proxiesand passes configured entries through TinyComputer’s private egress configuration. - Adds configuration, credential-redaction, and stable-configuration tests, plus usage documentation.
- Updates TinyComputer release pins, asset checksums, and lockfiles to v0.19.0.
| File | Description |
|---|---|
| docs/gitbooks/en/developing/tinycomputer-docker.md | Documents proxy setup, security checks, and limitations. |
| crates/openhuman-core/src/modules/registry/records_computer.rs | Pins TinyComputer v0.19.0 release assets and checksums. |
| crates/openhuman-core/src/modules/registry_computer_release_tests.rs | Updates expected release metadata and checksums. |
| crates/openhuman-core/src/modules/ops.rs | Passes browser configuration into callback-bound loading. |
| crates/openhuman-core/src/modules/desktop_tests.rs | Updates the load/refresh configuration consistency test. |
| crates/openhuman-core/src/modules/browser_egress_host.rs | Includes configured proxies in private egress configuration. |
| crates/openhuman-core/src/modules/browser_egress_host_tests.rs | Tests proxy serialization and unchanged empty configuration. |
| crates/openhuman-core/src/config/schema/tools/mod.rs | Re-exports the proxy configuration type. |
| crates/openhuman-core/src/config/schema/tools/browser.rs | Defines proxy settings with redacted debug output. |
| crates/openhuman-core/src/config/schema/tools/browser_tests.rs | Tests parsing, defaults, serialization, and debug redaction. |
| crates/openhuman-core/src/config/schema/mod.rs | Exposes the proxy type through the configuration schema. |
| crates/openhuman-core/src/config/ops_loader_and_search_tests.rs | Tests proxy credential redaction in snapshots. |
| crates/openhuman-app/Cargo.lock | Updates the desktop host’s TinyComputer bus version. |
| Cargo.lock | Updates workspace TinyComputer package versions. |
Review effort: Balanced
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ed093f12e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Downstream: teenydroid/brain#319 sets |

TinyComputer v0.19.0 re-pin
This PR pins TinyComputer v0.19.0 (tag commit
6d7624fb225ba2453d4cdaf48a31d22511703e77), which adds upstream-proxy routing to the browser egress proxy (tinyhumansai/tinycomputer#182).vendor/tinycomputeris at that gitlink, and thetinycomputerregistry record takes its asset digests verbatim from the release'schecksum.toml(scripts/modules/release-and-repin.mjs --version 0.19.0).Release: https://github.com/tinyhumansai/tinycomputer/releases/tag/v0.19.0
Related: tinyhumansai/tinycomputer#182, tinyhumansai/tinycomputer#183
What
Adds
[browser] upstream_proxies, which routes chosen destination domains through an upstream HTTP proxy. This is for sites that block the machine's own address, such as a datacenter range. Reddit, for example, answers every page from a VPS with "You've been blocked by network security".browser_egress_host::browser_dial_alias(config)adds the entries to TinyComputer's host-privatebrowser.egresssection asupstream_proxies([{url, domains}]). When the list is empty, the section is the bare alias as before, byte for byte, so a host without the setting sees no change and older TinyComputer releases still load. The callback-bound load (ops::computer_callback_config) and every refresh (desktop::proxy) build the same bytes.BrowserEgressHost::authorize(TinySecurity plus the never-open list) still sees every routed page. It also sees the upstream proxy's ownhost:port, which TinyComputer authorizes, consumes and dials like any other browser dial. TinyComputer then sendsCONNECT <approved address>to the proxy, so the proxy resolves nothing.BrowserUpstreamProxy'sDebugprintsurl: "[REDACTED]", and the config snapshot (config_snapshotRPC/tool) redacts the userinfo, because it already redacts any key namedurl. Nothing is logged except the number of entries.security-module). Changes take effect on the next core start.Tests
config/schema/tools/browser_tests.rs: TOML parse, default empty, not written back when unset,Debugredaction.modules/browser_egress_host_tests.rs: the bare alias keeps exactly its two keys, configured proxies ride in the private egress section, and the bytes are stable.modules/desktop_tests.rs: the callback-bound load config still equals every refresh.config/ops_loader_and_search_tests.rs: the snapshot redacts the proxy credentials and keeps the domains.modules/registry_computer_release_tests.rs: expects v0.19.0.Routing behaviour itself is tested upstream in tinycomputer#182, through the bus.
Docs
docs/gitbooks/en/developing/tinycomputer-docker.md, section 5, "Sites that refuse a datacenter address".Downstream: a teenydroid/brain PR (linked below once open) sets this from an operator secret.
Validation
node scripts/modules/release-and-repin.mjs tinycomputer --version 0.19.0: records rewritten from checksum.toml;check-module-pins.mjsok,check-submodule-monotonic.mjsok.cargo test -p openhuman --lib -- registry upstream_prox browser_dial_alias stable_alias callback_bound_load browser_egress_host: 479 passed. 1 failed (prompt_size::session_report_measures_the_visible_belt_not_the_registry, "security module unavailable: secret approval unavailable"), and it fails the same way on main on this machine because no security module is available locally.cargo metadata --lockedfor the root andcrates/openhuman-applockfiles.origin/main(e78115c, fix(wallet): harden the secondary Solana account and program signing #8740) in.crates/openhuman-app/Cargo.lockon main was already stale:--lockedfailed because main was missing theed25519-dalek/bs58closure that fix(wallet): harden the secondary Solana account and program signing #8740 added. This PR regenerates it offline. Root and app lockfiles now passcargo metadata --locked.Summary by CodeRabbit