Skip to content

fix(deps): upgrade zip to patched release - #12

Merged
senamakel merged 2 commits into
mainfrom
codex/zip-9-security-fix
Nov 15, 2026
Merged

senamakel merged 2 commits into
mainfrom
codex/zip-9-security-fix

Conversation

@senamakel

@senamakel senamakel commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Upgrade the CLI's zip dependency to 9.x to resolve the ZIP extraction advisories affecting versions 8.x. The installer iterates archive entries itself, and the existing extraction path checks enclosed entry names before writing them.

Public API or behavior changes: None. This updates the dependency and lockfile only.

Validation: cargo check --offline --manifest-path cli/Cargo.toml --all-features passed.

Summary by CodeRabbit

  • Chores
    • Updated internal project components without changing user-facing functionality or behavior.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T12:25:59.125402Z 3509240 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

  • cli/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c43d7af-66b9-4984-9c39-dd420609cfde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The CLI manifest updates the zip dependency requirement from version 8.2.0 to version 9. Its feature settings remain unchanged.

Changes: Zip dependency update

Layer / File(s) Summary
Update zip requirement
cli/Cargo.toml
The dependency requirement changes to version 9. Default features remain disabled, and the deflate feature remains enabled.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested reviewers: ctate

Merge Risk: Minimal · previous review 40276

The dependency upgrade is ready to merge; no actionable compatibility or extraction risk was found.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: upgrading the zip dependency to a patched release.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the crate today,
The zip version hops its way.
Deflate stays in the chosen mix,
While version nine joins the fix.
One small change, then off I bound,
With happy paws upon the ground.

ℹ️ Recent review info

⚙️ Run configuration

  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ae4875ed-b0da-42d9-83b5-78bb39630762
📥 Commits

Reviewing files that changed from the base of the PR and between 87a3220 and 4027616.

⛔ Files ignored due to path filters: 1

  • cli/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 1

  • cli/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@tinysweeper

tinysweeper Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Reviewed head: 4027616bc202356a35661d2329154ac6607d6233

Verdict: Ready for maintainer review · Priority: none
Coverage: Reviewed 1 of 2 files; not reviewed: cli/Cargo.lock.
Pull request purpose (title): fix(deps): upgrade z…

Diagnostics and supporting details

Full summary

Pull request purpose (title): fix(deps): upgrade zip to patched release. This pull request upgrades the CLI's `zip` dependency from 8.2.0 to 9.x to pick up patched releases addressing ZIP extraction advisories affecting 8.x. It is a dependency and lockfile update only: the manifest moves `zip` to 9 with default features disabled and `deflate` enabled, while the installer continues to iterate archive entries and check enclosed names before writing. No public API or behavior changes are intended.

Unreviewed paths

  • cli/Cargo.lock

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

Full pull-request behavior: `cli/Cargo.toml` bumps `zip` from 8.2.0 to 9 with `default-features = false` and `features = ["deflate"]`; `cli/Cargo.lock` resolves `zip` 9.0.5 with flate2/zopfli pulled in for deflate. The extraction path in `cli/src/install.rs` still uses `ZipArchive::new`, `by_index`, `enclosed_name`, `is_dir`, and `unix_mode`, so the existing enclosed-name containment check remains. Latest-push delta: unavailable — there is no trusted base-to-head diff comparison; the reviewed head is `4027616bc202356a35661d2329154ac6607d6233`.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change bumps the `zip` dependency from 8.2.0 to 9 in cli/Cargo.toml; cli/Cargo.lock already resolves zip 9.0.5, so the manifest and lockfile agree and the caret semantics are unchanged for other consumers. The only in-repo use is `ZipArchive::new`, `by_index`, `enclosed_name`, `is_dir` and `unix_mode` in cli/src/install.rs; the crate is not vendored, so I could not verify zip 9's API surface or MSRV from the repository, but nothing in the diff indicates a break. No defects found. _The code index is behind this pull request (indexed at `c9e62f5a42ee`), so retrieved context may be out of date._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: Answered with no reportable issues. This is a dependency-only bump, and the existing extraction path still uses `enclosed_name()` plus the containment check.
  • Lane summary: Dependency-only bump of the `zip` crate from 8.2 to 9 (locked to 9.0.5), with the existing archive extraction in cli/src/install.rs still using `enclosed_name()` plus a startswith containment check. No untrusted-input handling, permissions, or CI changes here; nothing reportable. _The code index is behind this pull request (indexed at `c9e62f5a42ee`), so retrieved context may be out of date._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: Answered with no sensitive content in committed files.
  • Lane summary: No sensitive content in committed files. _The code index is behind this pull request (indexed at `c9e62f5a42ee`), so retrieved context may be out of date._

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: This is a one-line dependency bump in cli/Cargo.toml, moving `zip` from 8.2.0 to 9 with `default-features = false, features = ["deflate"]`; the lockfile at the reviewed commit resolves to zip 9.0.5 with flate2/zopfli pulled in for deflate, consistent with the manifest change, and the installer's extraction path in cli/src/install.rs still uses the same `by_index`/`enclosed_name` APIs it did before. The title and body accurately describe the change as a dependency-only update, and I found nothing in the diff that misbehaves for a reachable input or violates a repository rule; the change is safe to merge as far as this diff shows. _The code index is behind this pull request (indexed at `c9e62f5a42ee`), so retrieved context may be out of date._
Evidence and run details
  • Models: deep, ladder/vectors-oai3, deepseek-v4.1-flash
  • Spend: $0.001976
  • Tokens: 196320 input · 16034 output · 5760 cached · 29 embedding
  • Updated: 2026-10-21T17:18:49Z
Head State Pass summary
4027616bc202 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-21T17:18:49Z)

tinysweeper 0.1.2

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

Diagnostics

Total spend: $0.0020

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel merged commit cb8cacf into main Nov 15, 2026
11 checks passed
@senamakel
senamakel deleted the codex/zip-9-security-fix branch November 15, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant