Repository navigation
fix(deps): upgrade zip to patched release - #12
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): fix(deps): upgrade zip to patched release. This pull request upgrades the CLI's `zip` dependency from 8.2.0 to 9.x to pick up patched releases addressing ZIP extraction advisories affecting 8.x. It is a dependency and lockfile update only: the manifest moves `zip` to 9 with default features disabled and `deflate` enabled, while the installer continues to iterate archive entries and check enclosed names before writing. No public API or behavior changes are intended. Unreviewed paths
Review snapshot
Completeness: Complete What changedFull pull-request behavior: `cli/Cargo.toml` bumps `zip` from 8.2.0 to 9 with `default-features = false` and `features = ["deflate"]`; `cli/Cargo.lock` resolves `zip` 9.0.5 with flate2/zopfli pulled in for deflate. The extraction path in `cli/src/install.rs` still uses `ZipArchive::new`, `by_index`, `enclosed_name`, `is_dir`, and `unix_mode`, so the existing enclosed-name containment check remains. Latest-push delta: unavailable — there is no trusted base-to-head diff comparison; the reviewed head is `4027616bc202356a35661d2329154ac6607d6233`. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Upgrade the CLI's
zipdependency to 9.x to resolve the ZIP extraction advisories affecting versions 8.x. The installer iterates archive entries itself, and the existing extraction path checks enclosed entry names before writing them.Public API or behavior changes: None. This updates the dependency and lockfile only.
Validation:
cargo check --offline --manifest-path cli/Cargo.toml --all-featurespassed.Summary by CodeRabbit