Repository navigation
Conversation
- set read-only top-level permissions on all workflows and grant write access per job only where needed (release, nightly, sponsors) - add missing permissions block to the e2e workflow - pin sqlc-dev/setup-sqlc to a commit sha - pin node, alpine and distroless base images to digests - let dependabot cover /e2e (npm) and /frontend (docker)
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
These are all fixes for suggestions from Dependabot / Code Scanning.
I used Claud Code to tell me what was needed and explain why they were needed to me.
Changes:
nightly.yml,release.ymlandsponsors.ymlnow give onlycontents: readat the top level. Write access is granted per job:create-releaseandupdate-releasecan write contents,image-build*can write packages and read contents, andimage-merge*can write packages.The extra
contents: readblocks are due to it replacing the root permissions configuration, so any changes are both consistent and explicit.e2e.ymlgets a top-levelcontents: readblock, which it didn’t have before.sqlc-dev/setup-sqlcinci.yml:32is now pinned to the SHA of v5.0.0.The node, alpine and distroless base images in Dockerfile, Dockerfile.distroless and frontend/Dockerfile.dev are pinned to digests. (Note that the
:latesttag changing will still download by the digest, but Dependabot will open a PR to update the digest when it changes.)Each digest is the multi-arch index, so arm64 builds still work.
/e2efor npm and/frontendfor docker.Because of the changes to the nightly action it might be worth triggering a manual run after merging to check it all works properly.
If my counting is right this should fix 16 Dependabot issues (but may open some new ones to update things).
Summary by CodeRabbit