Repository navigation
fix(deps): zip 9 for RUSTSEC-2026-0367, -0368 and -0369 - #2745
Merged
Merged
Conversation
Three advisories against zip 8 (permissions and symbolic links on extraction) fail cargo-deny on every pull request that changes Cargo.lock. zip 9.0.5 fixes them. Two test helpers of obc-draw name the write options as `SimpleFileOptions`, because `FileOptions` takes two lifetimes now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fixes: zip 9 gives the entry name as a Result, so the zip-slip refusal
printed `Ok("../escaped.txt")`. It now prints the raw name, and the test checks
it. obc-data-steps takes zip from the workspace, so a bump touches one manifest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR raises
zipfrom 8.6.0 to 9.0.5, in the workspace and inhost/obc-data-steps. Three test helpers, two inobc-drawand thecells_fixturetest ofobc-data-steps, now write their options aszip::write::SimpleFileOptions, becauseFileOptionstakes two lifetimes in zip 9. zip 9.0.5 adds one dependency,nix0.31 (MIT).Why
Three new advisories against zip 8 fail the
denyjob on every pull request that changesCargo.lock. Today that blocks #2739 and #2744.ZipArchive::extractfollows symbolic links out of the destination.The fix is zip 9.0.0 or later.
Tests
cargo check --locked -p obc-draw -p obc-data-steps --all-targetspasses.obc test -p obc-draw: 102 tests passed.cargo clippy --locked -p obc-data-steps -p obc-draw --all-targets --all-features -- -D warningsis clean.cargo-denyis not installed on this machine; CI runs it.Public docs: no change.
Requirements: none
🤖 Generated with Claude Code