Repository navigation
perf(planner): the snow bake skips HR-WSI files that miss a chunk - #2730
Merged
Merged
Conversation
…ore it opens them Each chunk tested every HR-WSI file of the region with `transform_bounds`, which holds the GIL. The footprint of each file in EPSG:3035 is now computed once per bake. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
planner/snowstep bakes one zoom-9 chunk at a time. Each chunk opened every HR-WSI file of the region and calledtransform_boundsbefore it tested the overlap.transform_boundssets up a new transform on each call and holds the GIL, so the 4 worker threads did not overlap.Now
laea_footprintgives the EPSG:3035 bounds of each file once per bake. A chunk skips a file that its extent does not touch, before it opens the file. The exact window test for the remaining files does not change.Measurement
Build:
f0d982ee2, on the DACHhr-wsisnapshot2026-10-16(2499 files, seasons 2016–2024), one thread, with another bake on the same machine.transform_boundscosts 26.5 ms per call with 1 thread and 26.8 ms with 4 threads. The running DACH bake does about 43 chunks per hour.Checks
python.repository-tools(331 tests): pass.check_data_sources.py,check_fixture_policy.py,prose.py --check,check_dependencies.py: pass.obc-data-stepsnextest,obc check fmtand the iOS host check. They do not cover this Python change, and a DACH bake used the shared cargo target. CI runs them.Public docs: not changed.
Requirements: none
🤖 Generated with Claude Code