Repository navigation
feat(web): planner place details on stops, quieter day list and comparison - #2729
Merged
Merged
Conversation
…y list - A selected place loads its website, phone and opening hours. A list search leaves them out, so the planner asks for them per place. - A night or a visit made from a place keeps the place id. Its callout shows the place, and its map pin shows the kind of place. - A pinned night in the day ladder opens its place. - Choose on a night makes that night the one a map pick ends. - The day list shows a day over target by its colour and bar only. - Route options open for the first route of a plan. Later, links under the summary open route options and the version comparison. An edit returns to the plan. - The version comparison deletes a version, with Undo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- An applied comparison row gives the focus to the link that opens it. - Only a place to sleep replaces a night pin's number with its kind. - The comparison header shows while the first route is calculated. - A day over target says so to screen readers. - Selecting the same place again retries failed details. - Search visits keep their place id. A moved point or a shaping point drops it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes six findings from a test of the web planner.
placeId). The callout of the stop shows the kind, the contacts and the opening hours. A night at a campsite, hotel or shelter shows that icon on its map pin instead of the day number. A moved point or a shaping point drops its place. A pinned night in the day ladder opens its place.pinNighttakes the place, so a new night never keeps the place of the night it replaces.Known limit
The prod search service answers the details request (
{q:'', source}) withInvalid planner search request, but the search code ondevelopaccepts it. So the deployed search is older than the code. Map-place details on prod have the same problem today. Until search is deployed again, the callout shows "Place details are unavailable" and, for a stop, its kind and the opening-hours block.Adversarial review
A subagent reviewed the first commit. The second commit fixes its findings: focus after Use this route and Restore, viewpoint icons on town nights, the missing comparison header while the first route is calculated, the over-target state for screen readers, retry on a second click of the same place, and
placeIdon search visits and moved points. The tests now check a night's own details request after a reload.Checks
npx vitest run src/lib/planner/ src/components/planner/: 315 passedpython3 tools/prose.py --check: passesnpm run check: 0 errors, 0 warningsnpm run test:planner --prefix builder/web/tests/browser: 4 passed, route requests 13 of 17Public docs: the plan contract
specs/planner-plan.mdnames the new optionalplaceIdfield, in its owndocs:commit.Requirements: none
🤖 Generated with Claude Code