Skip to content

feat(web): planner place details on stops, quieter day list and comparison - #2729

Merged
timohueser merged 3 commits into
developfrom
claude/route-planner-ux-fd78b2
Oct 17, 2026
Merged

timohueser merged 3 commits into
developfrom
claude/route-planner-ux-fd78b2

Conversation

@timohueser

@timohueser timohueser commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

This change fixes six findings from a test of the web planner.

  • Place contacts. A list search does not send the website and phone of a place. Before, the planner marked list results as complete and never asked for the details. Now a selected place loads its details through one cache, and the callout shows the website (as a link), the phone and the opening hours.
  • Stops keep their place. A night or a visit made from a place keeps the search id of the place (placeId). The callout of the stop shows the kind, the contacts and the opening hours. A night at a campsite, hotel or shelter shows that icon on its map pin instead of the day number. A moved point or a shaping point drops its place. A pinned night in the day ladder opens its place. pinNight takes the place, so a new night never keeps the place of the night it replaces.
  • Choose on night 2. Choose on a night in the ladder now makes that night the working night. A place callout and "Pick a spot on the map" then end that day, not day 1.
  • Day list. A day over its target shows only the coloured distance and the bar. The "km over target" note and Edit target stay in the opened day.
  • No tab bar. The Days · Route options · Versions control is gone. Route options open by themselves when a plan first gets a start and a finish (not for routes from search, GPX import or signed routes). After that, two quiet links under the summary open Route options and Compare versions. A comparison has a back button, and any edit returns to the plan.
  • Delete in the comparison. A previewed version offers Delete. The status line offers Undo.

Known limit

The prod search service answers the details request ({q:'', source}) with Invalid planner search request, but the search code on develop accepts it. So the deployed search is older than the code. Map-place details on prod have the same problem today. Until search is deployed again, the callout shows "Place details are unavailable" and, for a stop, its kind and the opening-hours block.

Adversarial review

A subagent reviewed the first commit. The second commit fixes its findings: focus after Use this route and Restore, viewpoint icons on town nights, the missing comparison header while the first route is calculated, the over-target state for screen readers, retry on a second click of the same place, and placeId on search visits and moved points. The tests now check a night's own details request after a reload.

Checks

  • npx vitest run src/lib/planner/ src/components/planner/: 315 passed
  • python3 tools/prose.py --check: passes
  • npm run check: 0 errors, 0 warnings
  • npm run test:planner --prefix builder/web/tests/browser: 4 passed, route requests 13 of 17
  • Manual check in a local dev server against prod data

Public docs: the plan contract specs/planner-plan.md names the new optional placeId field, in its own docs: commit.

Requirements: none

🤖 Generated with Claude Code

…y list

- A selected place loads its website, phone and opening hours. A list
  search leaves them out, so the planner asks for them per place.
- A night or a visit made from a place keeps the place id. Its callout
  shows the place, and its map pin shows the kind of place.
- A pinned night in the day ladder opens its place.
- Choose on a night makes that night the one a map pick ends.
- The day list shows a day over target by its colour and bar only.
- Route options open for the first route of a plan. Later, links under
  the summary open route options and the version comparison. An edit
  returns to the plan.
- The version comparison deletes a version, with Undo.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b7218500-f915-4a48-b33b-02ef14d56f38
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

timohueser and others added 2 commits October 17, 2026 09:53
- An applied comparison row gives the focus to the link that opens it.
- Only a place to sleep replaces a night pin's number with its kind.
- The comparison header shows while the first route is calculated.
- A day over target says so to screen readers.
- Selecting the same place again retries failed details.
- Search visits keep their place id. A moved point or a shaping point
  drops it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@timohueser
timohueser merged commit 912dc94 into develop Oct 17, 2026
28 checks passed
@timohueser
timohueser deleted the claude/route-planner-ux-fd78b2 branch October 17, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant