Repository navigation
feat(obc-data): check the Python groups before a capture and in the plan - #2726
Open
timohueser wants to merge 2 commits into
Open
timohueser wants to merge 2 commits into
timohueser wants to merge 2 commits into
Conversation
A Python step and a capture run `uv run --offline`. A group that is not installed failed late, with a uv download error. Now: - a capture checks its group before it starts; - a plan refuses to bake a step whose group does not start offline; - `obc doctor` checks the groups of the data steps, and `--install` installs them in the environment of `tools/obc.local`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python steps and the captures run
uv run --offline. A group that is not installed failed late, with a uv download error (for example,Failed to download h5py … Network connectivity is disabledin the era5-land capture). This change keeps--offlineand finds the problem early:obc doctor --install.uv run … pythonprefix of each baked step with-c "". A group that the uv cache holds installs offline, as the step would install it.obc doctorchecks the groups of the data steps.obc doctor --installinstalls them in the environment oftools/obc.local. A plainuv syncinstalls into.venvinstead.obc doctorlooked for the web builder venv only in.venv. It now readsUV_PROJECT_ENVIRONMENTfirst, as uv does.The spec said that
uv sync --all-groupsprepares the packages. That command fails, because the search groups conflict with the data groups. The spec now namesobc doctor --install.Public docs did not change (spec and README only).
Checks
cargo test -p obc-data: pass.cargo clippy -p obc-data --all-targets -- -D warnings: pass.cargo test -p obc-data-steps: the lib tests pass.planner_buildfails in the new worktree becausebuilder/web/node_modulesis missing (@mapbox/vector-tile). This does not come from this change. I did not runnpm ci, because a capture uses the network link. CI runs that suite.obc doctor: shows✓ Python groups (obc data).obc suites check,obc prose --check: pass.Requirements: none
🤖 Generated with Claude Code