Skip to content

feat(obc-data): check the Python groups before a capture and in the plan - #2726

Open
timohueser wants to merge 2 commits into
developfrom
claude/obc-data-python-groups
Open

timohueser wants to merge 2 commits into
developfrom
claude/obc-data-python-groups

Conversation

@timohueser

@timohueser timohueser commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

The Python steps and the captures run uv run --offline. A group that is not installed failed late, with a uv download error (for example, Failed to download h5py … Network connectivity is disabled in the era5-land capture). This change keeps --offline and finds the problem early:

  • A capture checks its group before it starts, and names obc doctor --install.
  • A plan refuses to bake a step whose group does not start offline. The check runs the uv run … python prefix of each baked step with -c "". A group that the uv cache holds installs offline, as the step would install it.
  • obc doctor checks the groups of the data steps. obc doctor --install installs them in the environment of tools/obc.local. A plain uv sync installs into .venv instead.

obc doctor looked for the web builder venv only in .venv. It now reads UV_PROJECT_ENVIRONMENT first, as uv does.

The spec said that uv sync --all-groups prepares the packages. That command fails, because the search groups conflict with the data groups. The spec now names obc doctor --install.

Public docs did not change (spec and README only).

Checks

  • cargo test -p obc-data: pass. cargo clippy -p obc-data --all-targets -- -D warnings: pass.
  • cargo test -p obc-data-steps: the lib tests pass. planner_build fails in the new worktree because builder/web/node_modules is missing (@mapbox/vector-tile). This does not come from this change. I did not run npm ci, because a capture uses the network link. CI runs that suite.
  • obc doctor: shows ✓ Python groups (obc data).
  • obc suites check, obc prose --check: pass.

Requirements: none

🤖 Generated with Claude Code

A Python step and a capture run `uv run --offline`. A group that is not
installed failed late, with a uv download error. Now:

- a capture checks its group before it starts;
- a plan refuses to bake a step whose group does not start offline;
- `obc doctor` checks the groups of the data steps, and `--install`
  installs them in the environment of `tools/obc.local`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c233bda1-4866-4fa9-95f2-184acedfc220
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant