Repository navigation
planner: the basemap tool downloads its dependencies before it packages - #2725
Merged
Merged
Conversation
…ackages On a machine whose Maven cache lacks a dependency, `mvn package` failed in the assembly plugin: "A required class was missing: org/apache/logging/log4j/spi/LoggerAdapter". The plugin cannot load the HTTP transport of Debian's Maven, so any download during `package` fails. The first DACH bake failed so; a second run passed, because the first had filled the cache. `dependency:go-offline` now resolves every plugin and dependency first, and `package` runs offline. With an empty cache, the old command failed and the new pair built the jar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first DACH bake failed in
fetch protomaps-basemaps@42ffaaa…: basemap tool preparation failed. Maven said: "A required class was missing while executing maven-assembly-plugin:3.8.0:single: org/apache/logging/log4j/spi/LoggerAdapter". The jars in the class path were complete; the stack trace shows the assembly plugin loading Maven's HTTP wagon, whose commons-logging finds log4j through the wrong class loader. A retry passed only because the failed run had filled~/.m2.tools/basemap_tool.pynow runsmvn dependency:go-offlinefirst, and thenmvn -o package, so no download happens duringpackage.Checks:
42ffaaa…, each with an empty-Dmaven.repo.local: the old command failed with the same error, also with-Dmaven.resolver.transport=native. The new pair builtprotomaps-basemap-HEAD-with-deps.jar(88.6 MB).test_planner_basemapchecks both calls.Public docs changed: no.
Requirements: none
🤖 Generated with Claude Code