Repository navigation
fix: rustls 0.23.46 for new advisories; obc ci with gh 2.102 - #2717
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cargo-deny refuses rustls 0.23.45: four advisories name 0.23.46 as the fix. ureq reads it in the workspace and in builder/desktop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gh 2.102 refuses to print a response with terminal escape sequences without `--allow-escape-sequences`, so `obc ci` printed no failure. `clean` already removes the escape sequences of each line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timohueser
force-pushed
the
claude/rustls-0.23.46
branch
from
October 15, 2026 19:11
93d71b4 to
dc02616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
denyfails on every pull request that selectsci.licenses, for example #2703. Four new advisories name rustls 0.23.45: RUSTSEC-2026-0346, -0347, -0348 and -0349. Each names 0.23.46 as the fix.cargo update -p rustls --precise 0.23.46in the workspace and inbuilder/desktop. ureq reads rustls; nothing else changes in the lockfiles.tools/licenses/THIRD-PARTY.mdnamesrustls 0.23.46. cargo-about 0.9.1 is not installed on this machine, so this one line is edited by hand; the licence texts of the patch release do not change, and thedenyjob checks the file with--check.obc ciprinted no failure with gh 2.102: gh refuses a response with terminal escape sequences without--allow-escape-sequences.tools/ci_log.pypasses the flag. Itscleanalready removes the escape sequences of each line.Checks:
cargo check --locked -p obc-data(builds rustls 0.23.46),python -m unittest tools.tests.test_ci_log, andpython3 tools/ci_log.pyon the failed run of #2703, which now prints the four advisories. Left out: no local cargo-deny (not installed here) and no desktop build; CI is the gate.Public docs changed: no.
Requirements: none
🤖 Generated with Claude Code