Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
鈩癸笍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 馃憖 while any review is running, comments if it has suggestions, and reacts with 馃憤 once all reviews finish with no findings. |
Each binding in the old scope tree records the name resolver's symbol for it: `let` and loop patterns, parameters, named functions, struct constructors and accessors, and natives. Debug assertions check that every binding's name matches its symbol's. Nothing reads the symbols yet; the next steps move lookups onto the resolver through them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timfennis
force-pushed
the
feat/bindings-carry-symbols
branch
from
October 13, 2026 14:47
d296278 to
a6e3049
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2, step 2, stacked on #231.
The old analyser chooses overloads by writing slot numbers, so lookups can't move to the resolver until both describe bindings the same way. This makes each binding in the old scope tree record the resolver symbol it corresponds to. The next steps can then look names up through the resolver and map the symbols back to the old slots.
ScopeBindinggainssymbol. Every creation site passes it:letand loop patterns, parameters, named functions, and struct constructors, getters and setters. They go through oneAnalyser::create_local_binding, which debug-asserts that the binding's name matches its symbol's. Natives get their symbols when the analyser is created, in registry order, with the same check.declared_symbol,struct_symbols,native_symbolsandsymbol_name.native_slotsfrom feat(analyser): record each native's registry slot 馃敘聽#231 is now read, so itsexpect(dead_code)is gone.scope.rsunit tests pass a placeholder symbol, since they test slots, not symbols.No behaviour change. All 747 tests pass with the assertions active. I checked that swapping a struct's getter and setter symbols makes the assertion fail.
馃 Generated with Claude Code