Repository navigation
feat(schema): ego_pose.imu and gravity-free acceleration - #321
Merged
Merged
Conversation
…e localization estimate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Planning review of the backfilled 1.0 samples found that
ego_pose.accelerationheld the raw IMU sample (gravity included, with a bias of about +0.5 m/s² at rest), while their planner uses Autoware's gravity-free estimate (/localization/acceleration, RMSE 0.12 m/s² against d(speed)/dt).Both are useful for planning team, so we add support for both in this PR.
ego_pose.acceleration: (ax, ay, az) in the vehicle frame, without gravity: the localization estimate, what Autoware feeds the planner. This reverses the "gravity included" line from feat(schema): caller-given metadata in V0Migrator.migrate (backfill) #319.ego_pose.imu:option[[float;6]]= (ax, ay, az, wx, wy, wz), the raw IMU in the vehicle frame: specific force with gravity (az ≈ +9.8 m/s² at rest) and angular velocity.ego_posesits at a sample time;twist,acceleration,imu,geocoordinateandcovariancehold the latest message at or beforetimestamp, best effort; the pose itself is interpolated.0.x
ego_pose.accelerationis dropped when loading or migrating a 0.x dataset. Checked on local datasets: where 0.x has it (22a86de5, 77f0c093), it is the raw Tamagawa IMU in FRD (az ≈ −9.8), so it is neither 1.0 field, and the IMU setup is not recorded in the dataset.V0Migratorwrites a note; the backfill restores both fields from the bag.Master sheet:
ego_pose.imuadded andaccelerationreworded as proposed.Tests
imuwith 3 values is rejected (test_invalid_record).accelerationmigrates with both fields null and the note.imu: null; its manifest hash is updated.