Repository navigation
docs(sanity): add T4Dataset 1.0 requirements - #311
Merged
Merged
Conversation
jacoblambert
force-pushed
the
v1/devkit-load
branch
from
October 14, 2026 11:10
e464a13 to
8976a22
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 14, 2026 11:10
41529ba to
5f08076
Compare
jacoblambert
force-pushed
the
v1/devkit-load
branch
from
October 15, 2026 03:36
8976a22 to
e08630f
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
2 times, most recently
from
October 15, 2026 05:23
1c95ad0 to
e01012d
Compare
jacoblambert
force-pushed
the
v1/devkit-load
branch
2 times, most recently
from
October 15, 2026 05:40
554bf6a to
5a4e45b
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 15, 2026 05:40
e01012d to
55a149c
Compare
jacoblambert
marked this pull request as ready for review
October 15, 2026 06:17
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 15, 2026 08:26
55a149c to
75414a6
Compare
jacoblambert
force-pushed
the
v1/devkit-load
branch
from
October 15, 2026 08:26
5a4e45b to
3990b9c
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 15, 2026 10:37
75414a6 to
d2ed161
Compare
jacoblambert
force-pushed
the
v1/devkit-load
branch
from
October 15, 2026 10:37
3990b9c to
bec3ce2
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 21, 2026 01:31
d2ed161 to
f21f675
Compare
jacoblambert
force-pushed
the
v1/devkit-load
branch
from
October 22, 2026 09:54
5072745 to
1ecdefa
Compare
jacoblambert
force-pushed
the
v1/sanity-spec
branch
from
October 22, 2026 09:55
f21f675 to
ab2563f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Specifies the
t4sanityrules for T4Dataset 1.0 datasets, before implementing them: new pagedocs/schema/v1/requirement.md(added to the Schema 1.0 docs), like the schema spec in #294.Docs only; no code change. 0.x datasets keep exactly the same rules and report.
How the rules were derived
Every 0.x rule was reviewed against the 1.0 format:
REC001–004,REC006,REC007, most record references, thenext/prevchecks,REF201andTIV001.FMT001–019),status.json,calibrated_sensor,lidarseg,.infofiles and the 0.x traffic-light table. The page lists each with why and the 1.0 rule that replaces it.STR010–015:manifest.json(supported version, listed files present, hashes, unlisted files, required tables, identity vs directory names).FMT020–040:manifest.jsonand one per 1.0 table, as in 0.x.REC008–027: what spans several records: unique sensor / instance indices, counts (nbr_samples,nbr_annotations),is_thing↔ instance, label provenance, key frames, frames per channel file, timestamps (order and unit),capabilitiesvs content, 0.x placeholders, routes, quaternions.REF015–025,REF107–108,REF204–207,REF302–306: references of the new and changed tables, mutualnext/prev, channel files matching theirsensorrow, and links to the lanelet2 map and inside LiDAR files (source_index, point labels).Conventions on the page:
t4sanityruns only the rules of the dataset's version.FMT.To decide in review
REC018key frames: the spec sayssample_data.sample_tokenisnullfor non-key frames, but the 0.x converter sets it for non-key frames too, and 2D labels on those frames reach their sample through it. Strict (ERROR, migration clears it) or relaxed?REC001one scene per dataset: kept for 1.0. Still true?REC023/REC024capabilities: declared but missing isERROR, present but not declared isWARNING.predictionandplanningare not checked;traffic_lightaccepts states or lamp instances.STR012hashes: reads every file, including videos and rosbags (GBs).ERRORbut meant to be excluded for quick checks; orWARNING/ opt-in?REC025placeholders: every dataset migrated without metadata backfill warns until it is backfilled. Intended as the signal.REC013first / last annotation: also checks they are the first / last in time. Some 0.x datasets leave them empty while labels exist, so migration has to recompute them (the rule is fixable).FMTper table (21 IDs, so a table can be excluded alone, as in 0.x) or one rule for all tables.Next
Implementation in stacked PRs after this one: version selection and
STR/FMT, thenREC, thenREF.