Repository navigation
feat(schema): add T4Dataset 1.0 table names and registry - #302
Merged
Merged
Conversation
jacoblambert
force-pushed
the
v1/schema-caption
branch
from
October 14, 2026 11:10
cf90237 to
b5cc177
Compare
jacoblambert
force-pushed
the
v1/registry
branch
from
October 14, 2026 11:10
ac7ce42 to
026ee95
Compare
jacoblambert
force-pushed
the
v1/schema-caption
branch
from
October 15, 2026 03:21
b5cc177 to
bda8459
Compare
jacoblambert
force-pushed
the
v1/registry
branch
from
October 15, 2026 03:21
026ee95 to
1c7ed79
Compare
jacoblambert
marked this pull request as ready for review
October 15, 2026 06:04
jacoblambert
force-pushed
the
v1/registry
branch
from
October 15, 2026 08:26
1c7ed79 to
9e4e40d
Compare
jacoblambert
force-pushed
the
v1/schema-caption
branch
from
October 15, 2026 08:26
bda8459 to
4432301
Compare
jacoblambert
force-pushed
the
v1/registry
branch
from
October 15, 2026 10:37
9e4e40d to
b719a1c
Compare
jacoblambert
force-pushed
the
v1/schema-caption
branch
from
October 15, 2026 10:37
4432301 to
152f563
Compare
jacoblambert
force-pushed
the
v1/registry
branch
from
October 21, 2026 01:31
b719a1c to
b8c2f1a
Compare
jacoblambert
force-pushed
the
v1/schema-caption
branch
from
October 21, 2026 01:31
152f563 to
7217eb6
Compare
ktro2828
approved these changes
Oct 21, 2026
jacoblambert
force-pushed
the
v1/schema-caption
branch
from
October 22, 2026 09:37
7217eb6 to
e3c3139
Compare
jacoblambert
force-pushed
the
v1/registry
branch
from
October 22, 2026 09:40
b8c2f1a to
a9a0ede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers the 1.0 table classes by name, so the loader (next PR) can build every table without a hard-coded list.
t4_devkit/schema/v1/name.py:SchemaNamefor the 1.0 tables (nocalibrated_sensor,surface_ann; addsvehicle,route,scenario,caption), withfilenameandis_optional(). Required tables:sample,sample_data,ego_pose,sensor,scene,log,vehicle.t4_devkit/schema/v1/registry.py: a 1.0SCHEMASregistry. Every 1.0 class registers itself with@SCHEMAS.register(SchemaName.X), as the 0.x tables do.Change to existing code
SchemaRegistry(t4_devkit/schema/tables/registry.py) takes the name enum it accepts as an argument, instead of only the 0.xSchemaName. The default is the 0.x enum, so existing code and the 0.xSCHEMASare unchanged. Each registry rejects names from the other version.Tests
tests/schema/v1/test_registry.py:<name>.json.force=True, as documented for 0.x.