Skip to content

chore: adopt suite conventions (AGENTS.md, ADRs, CI, templates, dependency-groups) - #163

Merged
susheem-k merged 2 commits into
mainfrom
worktree-conventions-pr1
Oct 14, 2026
Merged

susheem-k merged 2 commits into
mainfrom
worktree-conventions-pr1

Conversation

@susheem-k

Copy link
Copy Markdown
Collaborator

Summary

First pull request of the split in #162: bring the repository to the conventions of chronicle, primitives and the control plane. No runtime code changes.

  • AGENTS.md / CLAUDE.md (source of truth, target layers, invariants, 400-line rule), docs/adr/ (README, template, ADR 0001) and the adr skill.
  • CI: Ubuntu and Windows over Python 3.10 to 3.13, concurrency cancel, least-privilege permissions, build + twine check + wheel-contents check.
  • Repository hygiene: CodeQL, DCO check, PR-size notice, dependabot, CODEOWNERS, bug/feature/PR templates with a compatibility section.
  • dev tooling moves from the published [dev] extra to a PEP 735 [dependency-groups] entry (pip install --group dev); install docs updated.
  • The pre-commit mypy hook targets 3.12 so it can parse numpy stubs on newer interpreters.

Size

About 820 lines added, above the 400-line guideline. Almost all of it is boilerplate copied from the chronicle repository (workflows, templates, pr_size.py, ADR template and skill) and adapted by name. The hand-written part is AGENTS.md, the ADR README, CI and the CONTRIBUTING.md section.

Deferred

  • mypy --strict is not enabled here. It cannot pass until the code moves onto the layers (PRs 3 to 5), so CI keeps the current mypy configuration and strict lands with those PRs.
  • release.yml, version in one place, and the PyPI end-to-end job belong to later PRs of the split.

Compatibility

  • Compatible (additive only). Published metadata loses the [dev] extra; contributors use pip install --group dev (needs pip 25.1+).

Notes for review

  • This PR is the first run of the Windows and Python 3.13 matrix legs; failures there are existing issues surfaced, not regressions.
  • Not yet verified: the new codeql, dco and pr-size workflows were only validated as YAML and with zizmor locally.

Refs #162

🤖 Generated with Claude Code

susheem-k and others added 2 commits October 15, 2026 01:56
…dency-groups)

First of the issue 162 split. Adds AGENTS.md/CLAUDE.md and the ADR folder,
moves dev tooling from a published extra to a PEP 735 dependency group,
and brings CI and repository templates in line with chronicle: Ubuntu and
Windows over 3.10-3.13, build and twine check, wheel contents check,
CodeQL, dependabot, DCO check, PR-size notice, CODEOWNERS.

mypy --strict is deferred: it cannot pass before the layers move. The
pre-commit mypy hook now targets 3.12 so it can parse numpy stubs on
newer interpreters.

Refs #162

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: susheem-k <susheemkoul97@gmail.com>
- Pin the contract extra to agentplane-control-plane<1.0 and install it from
  PyPI in CI: the 0.4 code targets the 0.2 API, and control-plane main (1.0)
  breaks dev_plane.py (Settings(db_path=...)). The 1.0 move is PR 3 and 4.
- Drop the CodeQL workflow: the repository already runs CodeQL default setup
  and GitHub rejects advanced-configuration uploads alongside it.
- Read policy docs as UTF-8 in test_policy_names so the Windows legs do not
  decode with cp1252.

Refs #162

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: susheem-k <susheemkoul97@gmail.com>
@susheem-k
susheem-k merged commit 8039bc2 into main Oct 14, 2026
17 checks passed
@susheem-k
susheem-k deleted the worktree-conventions-pr1 branch October 15, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant