Conversation
patbeqo
added this pull request to stack #3083
September 16, 2026 22:06
patbeqo
force-pushed
the
patbeqo/otel-v2-workflow-prerequisites-2
branch
from
September 17, 2026 17:26
58542ea to
49a89cd
Compare
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
ActivityClientPluginandNexusClientPlugin, propagated from the service stubs toActivityClientandNexusClientthe same wayScheduleClientPluginreaches the schedule client, withsetPlugins/getPluginsonActivityClientOptionsandNexusClientOptions.SimplePluginimplements both, and its builder gainedaddScheduleClientInterceptors,addActivityClientInterceptors, andaddNexusClientInterceptors.configureScheduleClientnow applies its interceptors instead of being a no-op, so plugins no longer needconfigure*overrides to install interceptors on any client.PluginUtils.extractPlugins, which the two new sites also use.StartNexusOperationExecutionInputnow copies headers into a mutable, case-insensitive map, matchingExecuteNexusOperationInput, so header-adding interceptors can populate it in place as its javadoc describes. Previously it kept the caller'sCollections.emptyMap().Why?
The OpenTelemetry v2 plugin (#3046) traces every client-side operation Go does, but standalone activities and client-started Nexus operations had no plugin hook to install an interceptor through, and the schedule hook had no builder helper. This is the second prerequisite slice, stacked on #3049.
Breaking changes?
None. The public APIs are additive and experimental.
Server PR
None.
Test plan
./gradlew :temporal-sdk:test --tests 'io.temporal.common.*' --tests 'io.temporal.client.*'./gradlew :temporal-sdk:test -PtestServer=dev-server --tests 'io.temporal.client.nexus.*' --tests 'io.temporal.client.functional.StandaloneActivityTest' --tests 'io.temporal.client.schedules.*' --tests 'io.temporal.common.PluginPropagationTest'./gradlew :temporal-sdk:spotlessCheck./gradlew :temporal-sdk:javadoc