fix(http): prevent duplicate work across dispatch failure boundaries - #905
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 260e347a
Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-09-30T05:04:00Z
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 127da94a
Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-09-30T05:10:01Z
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 1bd34ad1
Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-09-30T05:11:01Z
Implemented
The shared HTTP adapter's broad retry catch restarted a worker on terminal HTTP refusals, result decoding and coordinator accounting failures. Its default two retries also repeated operations after a lost response. Worker cancellation could omit already settled receipts.
Exact-head qualification: passed
Head:
1bd34ad156ff78f4521e4012e48417ed247dedcc.Maintained CI run 36672177930 completed successfully, including both
ciandgepa-releasejobs:The first run stopped on formatter differences. Those were corrected in the owning source/test files; no gate was skipped or weakened. The successful run above is the corrected current head.
Behavioral evidence
The extended existing HTTP integration file uses real loopback sockets, actual filesystem effects and the native cost ledger. Its seven cases pass; five added cases fail against the unchanged original implementation.
The separate retained local reproduction exercised 15 observation groups, including response loss after effect, malformed response, missing artifact, accounting failure, cancellation, explicitly retried byte stability and cancelled backoff. Before/after effect counts were 3 -> 1 for failed workers, lost responses and failed receipt import; available settled cancellation receipts were preserved.
These groups overlap and are not independent reliability trials. Ledger amounts are synthetic. The earlier local reproduction used a historical dependency closure; it does not replace the fresh full-current-repository qualification now recorded above.
Reproduce
pnpm install --frozen-lockfile pnpm exec vitest run src/adapters/http.test.ts pnpm typecheck pnpm build pnpm verify:packagedocs/http-dispatch.mdrecords the default-retry migration, worker/coordinator accounting boundary, proof scope and production obligations.Coordination and limits
Independent from #902: that PR owns model-client fallback/attempt accounting; this PR touches only the distributed job transport and its existing integration file.
This does not establish that deployed Auto traffic used this adapter, provider-side exactly-once behavior, outer-orchestrator retry safety, disconnected-client reconciliation, live evaluator admission, policy activation or customer savings. No paid provider call, package version change, merge or deployment was performed. Independent review and current repository merge requirements remain applicable.