Skip to content

docs(readme): align contributing guide with repository conventions - #32

Merged
takecy merged 1 commit into
masterfrom
docs/readme-dev-guide
Oct 3, 2026
Merged

takecy merged 1 commit into
masterfrom
docs/readme-dev-guide

Conversation

@takecy

@takecy takecy commented Oct 3, 2026

Copy link
Copy Markdown
Owner

Issue

Overview

README の開発手順に、効果の無い記述と、リポジトリ規約(AGENTS.md)と矛盾する記述が残っていたので修正します。README の変更のみで、動作の変更はありません。

Development Workflow

  • DEBUG=* go run gih/main.go status → go run ./gih status
    • コード中に DEBUG 環境変数を読む箇所は無く、指定しても効果がありませんでした

Contributing > Pull Requests

  • ブランチ名の例: feature/amazing-feature → feat/amazing-feature(変更の種類をプレフィックスにする旨を追記)
  • 事前チェック: make test lint → make build && make test && make lint(AGENTS.md の PR 前チェックと一致させました)
  • コミットメッセージの例: 'Add amazing feature' → 'feat(syncer): add amazing feature'(Conventional Commits へのリンクを追加)
  • 外部コントリビューター向けの Fork 手順はそのまま残しています

確認事項

  • go run ./gih --help が動くことを確認済みです
  • make build / make test / make lint が通ることを確認済みです
  • Usage 節の gih checkout -b feature/new は gih の使い方の例(利用者自身のリポジトリでの操作)なので、変更していません

🤖 Generated with Claude Code

https://claude.ai/code/session_01FXUFCzQvvR8h6rqDy3HenX

@takecy
takecy force-pushed the docs/readme-dev-guide branch from 290425d to d65d248 Compare October 3, 2026 03:29
@takecy
takecy marked this pull request as ready for review October 3, 2026 03:31
Copilot AI balanced review requested due to automatic review settings October 3, 2026 03:31
@takecy
takecy merged commit 429c1e7 into master Oct 3, 2026
2 checks passed
@takecy
takecy deleted the docs/readme-dev-guide branch October 3, 2026 03:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The branch creation step still omits the mandatory .worktrees/ workflow.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Aligns README contribution instructions with repository conventions.

Changes:

  • Corrects the development run command.
  • Documents branch naming and Conventional Commits.
  • Updates required pre-PR checks.
File Description
README.md Updates development and contribution guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md

1. **Fork** the repository
2. **Create** a feature branch: `git checkout -b feature/amazing-feature`
2. **Create** a branch prefixed with the change type (`feat/`, `fix/`, `docs/`, ...): `git checkout -b feat/amazing-feature`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants