Repository navigation
Conversation
Fixes tailscale#57. Signed-off-by: jihtsan <15151999611@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizeparses slices backed by the caller's input and overwrites comment bytes before packing the result. Callers that retain their original JSONC buffer can therefore lose its comments.Document that the input may be modified and show
Standardize(bytes.Clone(b))for callers that need to preserve it. This follows the documentation option in #57 and the existing CLI's practice of copying its source buffer; runtime behavior and allocation costs stay the same.Validation with Go 1.26.6 on macOS:
bytes.Clonepreserved the original input and produced valid JSON.go test ./... ./cmd/hujsonfmt/...andgo vet ./... ./cmd/hujsonfmt/...passed.go doc Standardizedisplays the guidance;gofmt -d format.goandgit diff --checkwere clean.Linux/Windows CI was not run locally. Prepared and reviewed with Codex assistance; commit includes DCO sign-off.
Fixes #57.