fix: align profile create and edit with figma - #1332
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Staging suite dispatched against https://github.com/synonymdev/bitkit-android/actions/runs/35972167273 E2E specs use |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Staging was re-run against The https://github.com/synonymdev/bitkit-android/actions/runs/35988075469 |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…eader Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pwltr
left a comment
There was a problem hiding this comment.
No findings on the reviewed head. Manual checks done.
This PR aligns the Create Profile and Edit Profile screens with the v62 Figma handoff and makes the edit form scroll behind Cancel/Save, with the Cancel button blurring what passes under it. iOS twin: bitkit-ios#781.
Description
mailto:links open the mail app, and phone numbers (starting with+or under a phone-type label) andtel:links open the dialer; other text, including dates and IP addresses, stays plain.Out of Scope
ui/screens/profile/PubkyChoiceScreen.kt: the Figma "Profile Create or use existing" frame, including the Pubky Ring identity list, is unchanged.ui/screens/profile/PubkyChoiceScreen.kt: the "New pubky" caption and "Create profile" button text from the iOS review are left to feat: share pubky keys with pubky ring #1329, which rewrites this screen.ui/screens/contacts/EditContactScreen.kt: shares the edit form and picks up the same layout; not re-checked against its own Figma frame.Design
Preview
QA Notes
Manual Tests
regression:Edit Profile → content scrolls under the transparent top bar; tags still listed and editable.regression:Edit Profile → change name → Save: saved name keeps the typed casing.+1 555 123 4567): opens the dialer; plain-text links do nothing.regression:Contacts → contact → Edit: form renders and saves.Automated Checks
just compile,just testandjust lintlocally; all pass.