Repository navigation
Conversation
|
Install the latest version of pnx https://pkg.svelte.dev/sv/c/003923b1d17a3b009a4090b51cfccb6864dcb5e6 createOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 003923b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sacrosanctic
left a comment
sacrosanctic
left a comment
There was a problem hiding this comment.
the migration case is not handled.
| return value as YamlMapLike; | ||
| } | ||
|
|
||
| function isRangeWithinSafe(declared: string, requested: string): boolean { |
There was a problem hiding this comment.
the underlying function already has a try catch.
| let directory = path.resolve(cwd); | ||
| const root = path.resolve(workspaceRoot); | ||
|
|
||
| while (true) { |
| if (fs.existsSync(npmrc)) { | ||
| const match = fs | ||
| .readFileSync(npmrc, 'utf8') | ||
| .match(/^\s*save-exact\s*=\s*(true|false)\s*$/im); |
There was a problem hiding this comment.
.npmrc is an INI-formatted file. Can just parse it as such.
| function shouldSaveExact(workspace: Workspace): boolean { | ||
| const workspaceRoot = findWorkspaceRoot(workspace.cwd); | ||
|
|
||
| if (workspace.packageManager === 'pnpm') { |
There was a problem hiding this comment.
this is a user selection. Which can conflict with the configs in the repo.
|
It looks better, but still needs work. But more importantly, I'm not sure if we should be doing this at all. |
I'm also thinking about it... because we have also to support the other 20 packages maangers then. Let's see how far we should go. |
3 participants
Fixes #1371
Summary
save-exact=truefrom project/workspace.npmrcfiles when dependency versions are rewrittensaveExactfrompnpm-workspace.yamlcatalog:andcatalog:<name>specifiers in package.json and update the corresponding pnpm workspace catalog entry instead.npmrc, pnpm 11 workspace config, default catalogs, and named catalogssvpatch changesetValidation
mainat0a668cb96081561aa0ce2abde8de25d2150a756agithub.comduring clone; no local pass is claimed