set engineStrict config when package manager is pnpm

[pluxain]

Closes #1341

Description

Following the allowBuilds approach, we add the engineStrict config to the pnpm-workspace.yml if it is not already set.

Checklist

• Update snapshots (if applicable)
• Add a changeset (if applicable)
• Allow maintainers to edit this PR
• I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

[pkg-svelte-dev]

Install the latest version of sv from cdf5b97:

pnx https://pkg.svelte.dev/sv/c/cdf5b97d30801144fcec6b82ad3c2a94416e00f0 create

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1344

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

[changeset-bot]

🦋 Changeset detected

Latest commit: cdf5b97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
sv	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pluxain]

Hi, this is my first attempt to contribute to the project. I followed what was done for allowBuilds.

I miss some things though: for instance I could not run the branch locally to see if the generated project output was correct.

I also do not know if I should regenerate the snapshots or the changeset.

Any guidance is welcome! Cheers!

[sacrosanctic]

allowBuilds is public because add-on developers would use it for their own app. But I don't see why this needs to be public. It's just for scaffolding brand now templates.

As an aside, I didn't want to fix it cause the whole create logic should be rewritten which would make this a no brainer fix.

[manuel3108]

Hi, this is my first attempt to contribute to the project

Thanks for helping out!

I miss some things though: for instance I could not run the branch locally to see if the generated project output was correct.

What exactly was not working? Im pretty sure we are just missing something CONTRIBUTING.md

Snapshots should indeed be regenerated. Also a changeset is required here, since this is a public facing change, otherwise no new release will be triggered.

[pluxain]

What exactly was not working? Im pretty sure we are just missing something CONTRIBUTING.md

CONTRIBUTING.md says:

## Build and run

To build the project and all packages. Run the 'build' script:

```sh
# from root of project
pnpm build
```

This outputs into /packages/PACKAGE/dist/.

Run the 'cli' package:

```sh
pnpm sv
pnpm sv create
pnpm sv add
pnpm sv migrate
pnpm sv check
pnpm sv help
```

So I thought I should buid the project locally and run pnpm sv create but then I get this output:

[ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL] Command "sv" not found

[pluxain]

Also, when I try to regenerate the snapshots, using this (taken from the CONTRIBUTING.md file again):

pnpm build && pnpm test --project cli --update all

I receive this output and it runs forever:

$ vitest run --silent --project cli --update all

 RUN  v4.1.8 /home/calou/dev/@sveltejs/cli

│
■  The --tasks values all and prerequisite cannot be combined with other tasks.
│
└  Operation failed.

│
■  The --tasks values all and prerequisite cannot be combined with other tasks.
│
└  Operation failed.

│
■  Unknown migration task: missing
│  Available tasks: svelte-config, env-vars
│
└  Operation failed.

 ✓  cli  tests/migrate.ts (13 tests) 19ms

 ❯  cli  tests/cli.ts 2/5

 Test Files 1 passed (2)
      Tests 15 passed (18)
   Start at 14:55:24
   Duration 138.01s

[sacrosanctic]

That's a visual bug. I fixed it in the other PR.

[sacrosanctic]

[ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL] Command "sv" not found

This should work. What version of pnpm are you on and what folder did you run it in. Should be pnpm 11 and root respectively.

[pluxain]

run at the root of the project:

 pnpm --version

gives

11.27.1

(I removed the warning about packageManager and devEngines.packageManager specifying a different version.

But anywhere else on my machine:

 pnpm --version

yields

12.4.2

[jycouet]

TBH, I never use pnpm sv but always pnpm build && node ./packages/sv/dist/bin.mjs (from repo root).
Like this I'm using "raw node". I also had issues in the past with pnpm sv with a global installation.

Maybe we should tweak this in the readme? WDYT?

[sacrosanctic]

pnpm bootstraps node to the correct version we pinned. Which also means pnpm sv works whether you have a different version installed in global or none installed at all.

I think pnpm 11 works a lot better so I rather triage the problem.

[pluxain]

allowBuilds is public because add-on developers would use it for their own app. But I don't see why this needs to be public. It's just for scaffolding brand now templates.

As an aside, I didn't want to fix it cause the whole create logic should be rewritten which would make this a no brainer fix.

Hi Scott,

Do you mean in this case everything should happen in addEngineStrictIfPnpm ?

I tried to follow the approach for allowBuilds as I wasn't sure of why it is structure like that.

As I stated in my comment, I would rather have the engineStrict added in the pnpm-workspace.yml with allowBuilds in one go to avoid writing the file over. I do not want to have a misleading name addAllowBuildsIfPnpm which also have a side effect on engineStrict config. What do you say ?

[sacrosanctic]

Do you mean in this case everything should happen in addEngineStrictIfPnpm ?

Yes, keep it private.

one go to avoid writing the file over

You can write to the same file multiple times. We do it all the time in this codebase.

[pluxain]

I wanted to add one test for pnpm. My guess was to add it in the cli tests like so:

{ projectName: 'create-pnpm', args: ['--no-add-ons', '--install pnpm'] }

as my understanding is that we set the package manager throught the --install arg. But this does not work as those tests already have a --no-install which makes sense.

Is there another way to set the package manager for a create command without installing dependencies ?

If not, that would be nice to be able to select a package manager on its own and still be able not to install dependencies.

[sacrosanctic]

I'd like that too, im not sure how to current behaviour works. Can you look around and test it out. At the very least, we can document this.

[pluxain]

I'll have a look. In the meantime, maybe we could try to hijack the install step while in testing, running dry runs to avoid actually installing dependencies on disk. Not sure if viable and/or wanted and/or feasible.

[pluxain]

I looked into the testing process for the cli and I do not think that covering this PR is possible as it is unfortunately.

[sacrosanctic]

Ok, just summarize your findings and remove the draft status.

[sacrosanctic]

demo template also has a .npmrc

[pluxain]

Yes, and it was removed here