tigris: fix shadow-bucket and delete examples - #2469
Merged
Merged
Conversation
Delete guidance advertised a nonexistent --force flag and had the empty/non-empty deletion rule backwards. fly storage destroy has no --force; it prompts for confirmation unless --yes is passed, and deletion is unconditional regardless of bucket contents. Shadow bucket create/update examples were missing the required --shadow-name flag. flyctl rejects a partial shadow configuration (all five of name, access key, secret key, endpoint, region are required) before any provider call, so the old examples would fail as written.
kcmartin
added a commit
that referenced
this pull request
Sep 22, 2026
Merged to main on 18 September, after the 17 September zip the import branch was built from, so it was absent from the MDX. Both shadow bucket commands were missing the required --shadow-name flag, so the documented examples would not run as written. The attribute count is now stated as five and they are named, and the bucket deletion paragraph says that deletion removes every object and that --yes skips the confirmation for automation.
kcmartin
added a commit
that referenced
this pull request
Sep 23, 2026
main carried five commits the import branch did not: the tigris fixes (#2469), three typo PRs (#2479, #2480, #2481) and the flyctl bot's self-merge during the freeze (#2492). All five were ported by hand onto the import branch as af90506, 4349021, f14985e, e898501 and 1a870b1, so their content is already here in MDX form. Git still reported ten conflicts, because rename detection pairs each .html.markerb with its converted .mdx and cannot merge a Sitepress edit into a converted file. None of them was a real disagreement, so the tree is resolved to the import branch in full rather than file by file. Both parents are kept. sitepress-final marks main as it stood immediately before this, at 1976805.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two customer-facing defects on the Tigris storage page:
--forceflag and had the empty/non-empty deletion rule backwards.fly storage destroyhas no--force; it prompts for confirmation unless--yesis passed, and deletion is unconditional regardless of bucket contents.--shadow-nameflag. flyctl rejects a partial shadow configuration client-side (all five of name, access key, secret key, endpoint, region are required) before any provider call — the old examples would fail as written.Verification
Independently reviewed by two separate models across multiple passes, all claims re-verified directly against current flyctl source (
internal/command/extensions/tigris/{destroy,create,update,tigris}.go), not against the docs' own prior wording.Scope note
A related edit (documenting shadow-bucket update semantics for
--shadow-write-through) is intentionally left out of this PR — see #2470, opened as a draft, blocked on a separate flyctl fix that hasn't merged yet. Shipping that wording now would describe behavior that isn't live yet.