Repository navigation
fix(replay): config.lessons adds the Lessons to a named Source list too - #156
Merged
Merged
Conversation
A replay given a Bot version's Source list ignored config.lessons, so a lessons arm silently replayed without Lessons. Claude-Session: https://claude.ai/code/session_01UDNLNu854ULHbHSL59UJKu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A replay given a Bot version's Source list (
config.sources) ignoredconfig.lessons, so a "lessons" arm replayed without Lessons, silently. Found while running the #143 lessons replay: 6 such arms came back with no Lessons in any prompt.ReplayHarness.run: withlessonsset and a named list that lackslessons, the Source is appended. The default Bot Flip briefs into the decide lane (was EAI-192) #1 lanes are unchanged.test_a_replay_with_named_sources_still_reads_lessons_when_asked.Replay only; nothing on the live path changes. 1039 tests pass, ruff clean.
https://claude.ai/code/session_01UDNLNu854ULHbHSL59UJKu