Skip to content

Pin Rust 1.100.0 and add journal, Stop and fixture-privacy checks - #15

Merged
sudo-py-dev merged 1 commit into
mainfrom
pin-rust-and-test-guards
Nov 13, 2026
Merged

sudo-py-dev merged 1 commit into
mainfrom
pin-rust-and-test-guards

Conversation

@sudo-py-dev

Copy link
Copy Markdown
Owner

What changed

  • Rust pinned to 1.100.0 everywhere: every dtolnay/rust-toolchain step in
    build.yml, release.yml and windows-preview.yml, the Snap recipe, and a new
    rust-toolchain.toml so local builds match CI. Fuzzing keeps cargo +nightly.
  • Journal ring test: the wrap arithmetic moved into ring_index and is tested
    (blocks past the end continue at s_first; a second wrap is refused).
  • Stop recovery test: a source that raises the stop flag during its first read;
    recovery fails and the folder is left empty (no file, no temporary file). Confirmed
    to fail when the stop check is disabled.
  • Audit rule PRIV-FIXTURE (CWE-538): files under tests/fixtures, including
    gzip contents, must not contain /home/<user>, /run/media/<user>,
    /Users/<user> or \Users\<user>. Confirmed to fail on the original ext2 image
    that leaked a user name. Reads and inflation are size-capped.

Why

Rust 1.100 reached CI unannounced and broke Clippy while local builds used 1.99.
The tests and audit rule cover gaps left by the previous PR.

Checks

cargo fmt --check, Clippy with -D warnings for Linux and the Windows target,
and all 193 tests pass on 1.100.0.

Reviewer notes

  • Updating Rust now means changing three places together: the workflows,
    snap/snapcraft.yaml and rust-toolchain.toml.
  • Developers need 1.100.0 installed; rustup reads rust-toolchain.toml and may
    need rustup toolchain install 1.100.0 on older rustup versions.

🤖 Generated with Claude Code

CI installed whatever "stable" was that day, so Rust 1.100 arrived
unannounced and broke Clippy while this machine still built with 1.99.
Every workflow, the Snap recipe and a new rust-toolchain.toml now use
1.100.0; update them together, on purpose.

- Test the ext journal ring: logged blocks past the end continue at the
  start of the log, and a second wrap is refused.
- Test Stop recovery: a large file stops mid-copy and leaves neither the
  file nor its temporary file behind.
- Audit test fixtures, inside gzip too, for local user paths such as the
  /run/media/<user> mount point that ext images record when mounted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
reclaim Ready Ready Preview Nov 13, 2026 7:13am UTC

@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bface256-7ed7-40ee-80f1-3b0df57c12d7
Commits

Reviewing files that changed from the base of the PR and between 46243a0 and eb1b634.

Files selected for processing: 11

  • .github/workflows/build.yml
  • .github/workflows/release.yml
  • .github/workflows/windows-preview.yml
  • docs/DISTRIBUTION.md
  • docs/TESTING.md
  • rust-toolchain.toml
  • snap/snapcraft.yaml
  • src/allocation/journal.rs
  • src/recovery_tests.rs
  • tests/audit/main.rs
  • tests/audit/rules.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sudo-py-dev
sudo-py-dev merged commit a147d67 into main Nov 13, 2026
9 checks passed
@sudo-py-dev
sudo-py-dev deleted the pin-rust-and-test-guards branch November 13, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant