Repository navigation
Pin Rust 1.100.0 and add journal, Stop and fixture-privacy checks - #15
Merged
Merged
Conversation
CI installed whatever "stable" was that day, so Rust 1.100 arrived unannounced and broke Clippy while this machine still built with 1.99. Every workflow, the Snap recipe and a new rust-toolchain.toml now use 1.100.0; update them together, on purpose. - Test the ext journal ring: logged blocks past the end continue at the start of the log, and a second wrap is refused. - Test Stop recovery: a large file stops mid-copy and leaves neither the file nor its temporary file behind. - Audit test fixtures, inside gzip too, for local user paths such as the /run/media/<user> mount point that ext images record when mounted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dtolnay/rust-toolchainstep inbuild.yml,release.ymlandwindows-preview.yml, the Snap recipe, and a newrust-toolchain.tomlso local builds match CI. Fuzzing keepscargo +nightly.ring_indexand is tested(blocks past the end continue at
s_first; a second wrap is refused).recovery fails and the folder is left empty (no file, no temporary file). Confirmed
to fail when the stop check is disabled.
PRIV-FIXTURE(CWE-538): files undertests/fixtures, includinggzip contents, must not contain
/home/<user>,/run/media/<user>,/Users/<user>or\Users\<user>. Confirmed to fail on the original ext2 imagethat leaked a user name. Reads and inflation are size-capped.
Why
Rust 1.100 reached CI unannounced and broke Clippy while local builds used 1.99.
The tests and audit rule cover gaps left by the previous PR.
Checks
cargo fmt --check, Clippy with-D warningsfor Linux and the Windows target,and all 193 tests pass on 1.100.0.
Reviewer notes
snap/snapcraft.yamlandrust-toolchain.toml.rust-toolchain.tomland mayneed
rustup toolchain install 1.100.0on older rustup versions.🤖 Generated with Claude Code