Repository navigation
Fix website accessible-name and color-contrast issues - #43
Merged
Merged
Conversation
The header logo link had aria-label "FMX home" while its visible text reads "FMX Free Media Xpress", so voice-control users could not target it by what they see. Drop the label (and its unused translation) and let the visible text name the link. Darken ten small grey and green text colors so every text element meets WCAG AA 4.5:1 against its background, keeping the same hues. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes two accessibility audit findings on the website, across all six language pages.
Elements must have their visible text as part of their accessible name
aria-label="FMX home"while its visible text reads "FMX Free Media Xpress", so voice-control users couldn't target it by what they see.hometranslation key from all five catalogs.Elements must meet minimum color contrast ratio thresholds
.mp4 ↗ .mp3arrow, media-type separators, format tags, "✓ Complete", greeting samples, release status/intro on the downloads band, card details, download note).--muted(#647068→#636e66), which was at 4.49:1 on the downloads background.For reviewers
dist/is regenerated withcargo run --releaseinwebsite/.node --test website/tests/i18n.test.js: 6 pass.main.🤖 Generated with Claude Code