Skip to content

BCGSTAB: do not return the initial guess as the best iterate #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rois1995 wants to merge 4 commits into
base: develop
Choose a base branch
from
+4 −4
Open

BCGSTAB: do not return the initial guess as the best iterate #2979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85594a8
BCGSTAB: do not return the initial guess as the best iterate
rois1995 Oct 15, 2026
e5ced69
Update the reference values of the wedge regression test from CI
rois1995 Oct 15, 2026
d052f7c
Merge remote-tracking branch 'origin/develop' into fix_bcgstab_initia…
rois1995 Oct 15, 2026
850358e
Update the reference values of turbmod_sa_neg_rae2822 from CI
rois1995 Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Common/src/linear_algebra/CSysSolve.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@ unsigned long CSysSolve<ScalarType>::BCGSTAB_LinSolver(const CSysVector<ScalarTy

ScalarType alpha = 1.0, omega = 1.0, rho = 1.0, rho_prime = 1.0;
ScalarType norm_best = norm_r;
if (config->GetComm_Level() == COMM_FULL) x_best = x;
Comment thread
rois1995 marked this conversation as resolved.
p = ScalarType(0.0);
v = ScalarType(0.0);
r_0 = r;
Expand Down Expand Up @@ -1198,7 +1197,7 @@ unsigned long CSysSolve<ScalarType>::BCGSTAB_LinSolver(const CSysVector<ScalarTy
/*--- Check if solution has converged, else output the relative residual if necessary ---*/

norm_r = r.norm();
if (norm_r < norm_best) {
if ((i == 0) || (norm_r < norm_best)) {
norm_best = norm_r;
x_best = x;
}
Expand All @@ -1211,7 +1210,8 @@ unsigned long CSysSolve<ScalarType>::BCGSTAB_LinSolver(const CSysVector<ScalarTy
}
}

/*--- BCGSTAB does not reduce the residual monotonically, return the best iterate. ---*/
/*--- BCGSTAB does not reduce the residual monotonically, return the best iterate.
* The initial guess is not a candidate, returning it would mean no update at all. ---*/

if ((config->GetComm_Level() == COMM_FULL) && (norm_r > norm_best)) {
x = x_best;
Expand Down
2 changes: 1 addition & 1 deletion TestCases/parallel_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ def main():
turbmod_sa_neg_rae2822.cfg_dir = "turbulence_models/sa/rae2822"
turbmod_sa_neg_rae2822.cfg_file = "turb_SA_NEG_RAE2822.cfg"
turbmod_sa_neg_rae2822.test_iter = 10
turbmod_sa_neg_rae2822.test_vals = [1.275994, 1.062588, -2.067822, 1.300662, 0.480881, 0.000000]
turbmod_sa_neg_rae2822.test_vals = [1.316535, 1.043996, 4.236921, 1.270979, 0.463385, 0.000000]
turbmod_sa_neg_rae2822.test_vals_aarch64 = [-1.345593, 1.448310, 1.208721, -0.846597, 1.248410, 0.489117, 0.000000]
test_list.append(turbmod_sa_neg_rae2822)

Expand Down
Loading