Repository navigation
chore: move the Bun pin to 1.4.3 - #565
Merged
Merged
Conversation
Bun 1.4.3 already builds the MCP broker. The main pin now matches it, so CI, the sidecar and the release builds use one Bun. Bun 1.4 is also the first release with bun:ffi on Windows ARM64, which a native ARM64 Windows build needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Bun pin moves from 1.3.14 to 1.4.3. That covers
.bun-versionand everybun-version:in the workflows, asdocs/bun-version-policy.mdrequires. The MCP broker already builds with 1.4.3 (packages/mcp-broker/mise.toml), so after this change one Bun builds everything.Why now:
node:http. The broker moved to 1.4 for that reason (see the policy doc).bun:ffion Windows ARM64. 1.3.14's ARM64 build has TinyCC disabled. A native ARM64 Windows build needs FFI for the MCP broker's Job Object containment.Checked on 1.4.3
bun test: 2349 pass, 0 fail.bun run check:fast,knipandbun run check:deepare clean.bun run app:sidecarbuilds the UI, the sidecar and the broker on macOS. The compiled sidecar starts,/statusreports ok, and/ui/settings/,/ui/dashboard/and/token-usage/sessionsanswer./status, and serve Settings.bun:ffidlopenof kernel32 works on 1.4.3 for both arm64 and x64. On 1.3.14 arm64 it fails with "TinyCC is disabled".Not checked
bun run app:dev). The next rc tests that on macOS and Windows.