Repository navigation
Add Quick print-to-PDF and exact document exports - #263
Merged
Merged
Conversation
Run both the document output finish step and the signature-check finish step after an Action List job, so neither outcome is dropped. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lqo8EDq3w2nU1zekEZDoZc
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lqo8EDq3w2nU1zekEZDoZc
Keep both published-output records side by side. The Action List worker still records the in-memory published bytes that the export and receipt use, and now also records the published path that the undo and redo history tracks. The editor host clears and sets both together. Both sides' tests stay, the command catalog takes the union of the two branches' implemented commands, and the facade test expects the 30 implemented commands. The quick PDF parity note lists print and export and undo and redo as done. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lqo8EDq3w2nU1zekEZDoZc
mberrys
marked this pull request as ready for review
October 11, 2026 11:07
The editor host constructor now takes the settings store first, then the parent and recipes directory. The merged tests still used the old two-argument form, which fails to compile. Pass a null settings argument at each recipe-path call. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lqo8EDq3w2nU1zekEZDoZc
The settings-first constructor exists only on the epic branch. This branch still builds against dev, where the constructor takes the parent and the recipes directory, so the test calls I changed here do not compile. Restore the calls to the dev form. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lqo8EDq3w2nU1zekEZDoZc
mberrys
pushed a commit
that referenced
this pull request
Oct 11, 2026
Bring in the print and export commands from #263. Keep this branch's finish steps and availability updates alongside dev's document output step and the print and export availability. Keep both sides' editor host tests, with the print and export tests first and the display-mode test after them. Take the union of both branches' implemented commands and regenerate the handler ratchet, which now records 48 gaps. The facade test expects the 55 implemented commands. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lqo8EDq3w2nU1zekEZDoZc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123.
Quick operators can now use File → Print to PDF and Export document. Print-to-PDF and current-page PNG/TIFF output use Core's transparency renderer, with explicit fidelity acknowledgment and renderer, resolution, color, revision, and artifact identity in the result. PDF export preserves the accepted correction's exact published bytes and links them to Core's existing mutation receipt; original-input exports verify the loaded source digest. Stale, cancelled, incomplete-render, permission-restricted, and source-overwrite requests fail before destination publication.
Scope follows the approved print-to-PDF and export choice. Native printer spooling is deferred. Annotation appearances remain an acknowledged fidelity limitation; raster output is a color-managed RGB composite. No Widgets or PrintSupport dependency, protected Core interface, or receipt schema changes.
Validation at head
b9dccb3aa620820b6739542be2066f3d065314dd:check-changerun (148.88 seconds), including the complete Editor host, Action List, product operator, shell keyboard, and workspace suites.ProductQuickAccessibilitySmoke --preview-fixtures loop-preflight/testdata/fixturespassed with the edited QML, software rendering, andnative_accessibility_backend_active=0.python scripts/agent/check-change.py --base origin/dev --build-dir C:/Users/micha/AppData/Local/Temp/loop-issue123-build --report C:/Users/micha/AppData/Local/Temp/loop-issue123-proof.jsonpassed: format, affected builds, clang-tidy, source/architecture contracts, and all 23 mapped suites. Static analysis passed the configured policy; it still emitted existing/header diagnostics.The focused visual fixture command was
UnitTestsEditorHost.exe outputBytesAndFences outputPublishedPacket outputRenderFormats outputOverprintWarning outputRenderFailure fixJourneyPublishesOnlyAnApprovedPlanBoundToTheDisplayedIdentitywith the Qt runtime on PATH andQT_QPA_PLATFORM=offscreen. The external native-test log records these per-run identities:370bc05952f29a458ba6904fb48f7c4dbee41261c4026deaa390e89c81c6e7c49a7aef9c3d822a62edd0207cea72da86d118cc8f07ed6d578e6b6d2e213f0129370bc05952f29a458ba6904fb48f7c4dbee41261c4026deaa390e89c81c6e7c46a32647618b13a2dcc0a1791bde9893b58c0a14fa26ec245af0e0dfe079cd70eefe6c17a79011eb3988527112d73efb555d37e79f13b7192f6b8fa9193dce3ac8c3b7e0f8e9be72fbf24b589904fe059c8765700a4a35471bb0bdf64e806d7a5The tests reopen and render the print PDF, check black/white content and page geometry, verify raster pixels/resolution, and compare output hashes. PDF fixture and print hashes vary with generated PDF metadata.
Hosted checks at the same head: CodeQL, Documentation truth, and Supply Chain Policy passed. CI run 38089727912 remains in progress.
Draft qualification boundary: clean-machine Windows and Linux print-to-file lanes have not been performed. The local Quick smoke used software rendering and reported native_accessibility_backend_active=0. This PR does not claim those lanes or print proof.
Anti-slop review: reused Core rendering, artifact identity, governed publication receipts, and the safe writer. Removed stale explanatory test comments and added an explicit render-error refusal; retained cancellation, revision, provenance, and atomic-publication checks.