[polaz]

Summary

• The CI test job runs the lsm tests, which every test run compiled out until now.
• expect_window_descriptor_mismatch_fails_before_decode compresses past the default level's largest window, so its frame carries a window descriptor; a one-shot frame of known size is single-segment, as upstream emits it.

Changes

• .github/workflows/ci.yml: lsm joins the first suite's feature set.
• zstd/src/decoding/frame_decoder/tests.rs: 3 MiB input instead of 512 KiB, with the reason at the test.

Testing

• cargo nextest run -p structured-zstd --features hash,std,dict-builder,lsm passes locally; fmt clean.

Closes #607

Summary by CodeRabbit

• Tests
  • Expanded automated test runs to cover LSM functionality.
  • Updated frame-decoding checks to verify behavior with larger payloads and window-descriptor mismatches. These changes improve coverage of compression and decoding scenarios without changing the public interface or user-facing behavior.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-18T22:41:29.914735Z	03b9ee0	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: structured-world/structured-zstd/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 59fc0a83-3d84-42f4-aa4b-57396dbc6759

📥 Commits

Reviewing files that changed from the base of the PR and between 15e4dec and 03b9ee0.

📒 Files selected for processing: 2

• .github/workflows/ci.yml
• zstd/src/decoding/frame_decoder/tests.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The CI test command now enables lsm. The window-descriptor mismatch test uses a 3 MiB payload and documents when known-size inputs omit the window descriptor.

Changes: LSM Test Coverage

Layer / File(s)	Summary
Window descriptor test and CI coverage .github/workflows/ci.yml, zstd/src/decoding/frame_decoder/tests.rs	The test fixture increases from 512 KiB to 3 MiB, and its comments describe when known-size inputs omit the window descriptor. The CI test command adds the lsm feature.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: myers

Merge Risk: ⚪ Minimal · up to 03b9e

The LSM tests are included across the configured operating systems, and the mismatch test verifies early rejection when a descriptor is present. No actionable merge risk remains.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes both main changes: enabling LSM tests in CI and fixing the affected window-descriptor test.
Linked Issues check		Issue [#607] requires the lsm tests to run in CI and requires the window-descriptor test to use input larger than the default 2 MiB window. The CI test command now enables lsm with `hash,std,dic…
Out of Scope Changes check		The diff changes only the CI feature set and the payload and comments in expect_window_descriptor_mismatch_fails_before_decode. Both changes directly implement issue [#607]. No unrelated behavior or…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …

Full details: Linked Issues check

Explanation

Issue [#607] requires the lsm tests to run in CI and requires the window-descriptor test to use input larger than the default 2 MiB window. The CI test command now enables lsm with hash,std,dict-builder,lsm. The test payload now uses 3 MiB and documents why this produces a window descriptor. The PR reports that cargo nextest run -p structured-zstd --features hash,std,dict-builder,lsm passes.

Full details: Out of Scope Changes check

Explanation

The diff changes only the CI feature set and the payload and comments in expect_window_descriptor_mismatch_fails_before_decode. Both changes directly implement issue [#607]. No unrelated behavior or files are changed.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!