Skip to content

Delete unused assembly processors - #3679

Merged
xen2 merged 1 commit into
stride3d:masterfrom
ds5678:delete-unused-assembly-processors
Oct 23, 2026
Merged

xen2 merged 1 commit into
stride3d:masterfrom
ds5678:delete-unused-assembly-processors

Conversation

@ds5678

@ds5678 ds5678 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

PR Details

This pull request deletes unused assembly processors.

  • InteropProcessor
  • RenameAssemblyProcessor

Both of these might have had some purpose in the past, but they currently have no effect on the build.

Related Issue

Part of #1835

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

Note

This conflicts with #3593 . I'll rebase after one of them is merged.

@Kryptos-FR

Copy link
Copy Markdown
Member

The rename feature might be useful. Just because it isn't used now doesn't mean it won't in the future. It was primarly used when Xenko became Stride.

@ds5678

ds5678 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

The rename feature might be useful. Just because it isn't used now doesn't mean it won't in the future. It was primarly used when Xenko became Stride.

I'm not sure in what context this would be used, especially since you can change the name with AssemblyName in csproj files. Can you give an example?

* InteropProcessor
* RenameAssemblyProcessor
@ds5678
ds5678 force-pushed the delete-unused-assembly-processors branch from fd6aa05 to 5ee20b9 Compare October 23, 2026 20:41

@xen2 xen2 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the rename feature: I think it's fine to remove it. Nothing in the build passes --rename-assembly anymore, AssemblyName in the csproj covers the normal case, and if we ever need it again for something like the Xenko -> Stride rename, we'll figure another way since the AssemblyProcessor will likely be gone.

@xen2
xen2 merged commit aa46fb9 into stride3d:master Oct 23, 2026
31 checks passed
@ds5678
ds5678 deleted the delete-unused-assembly-processors branch October 23, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants