Skip to content

fix(accessors): honor map slice defaults #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanzei merged 2 commits into from
Oct 24, 2026
Merged

fix(accessors): honor map slice defaults #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2fdce
fix(accessors): honor map slice defaults
terminalchai Oct 23, 2026
4abb532
test(accessors): trim default regression coverage
terminalchai Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions type_specific.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,9 @@ func (v *Value) ObjxMapSlice(optionalDefault ...[]Map) []Map {
case map[string]any:
result[i] = New(s[i])
default:
if len(optionalDefault) == 1 {
return optionalDefault[0]
}
return nil
}
}
Expand Down
16 changes: 16 additions & 0 deletions type_specific_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,3 +456,19 @@ func TestCollectObjxMap2(t *testing.T) {
assert.Equal(t, collectedArr[4], 4)
}
}

func TestObjxMapSliceDefaultFromJSON(t *testing.T) {
m := objx.MustFromJSON(`{"rows":[{"id":1},false]}`)
fallback := []objx.Map{{"fallback": true}}

assert.Equal(t, fallback, m.Get("rows").ObjxMapSlice(fallback))
}

func TestObjxMapSliceInvalidElementDefaults(t *testing.T) {
fallback := []objx.Map{{"fallback": true}}
for _, invalid := range []any{nil, "not a map"} {
value := objx.Map{"rows": []any{invalid}}.Get("rows")
assert.Equal(t, fallback, value.ObjxMapSlice(fallback))
assert.Nil(t, value.ObjxMapSlice())
}
}
Loading