Repository navigation
Give each journal balance change its own new balance - #79
Merged
Merged
Conversation
An account changed twice between two journal reads got the final balance for both changes, counting the second amount twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the balances the inspector records when one account's balance changes several times between two journal reads, and prepares the
base-v2.5.2.8-fh3.1-2release notes.0x79transaction whose payer is also the block beneficiary gets its refund and its tip after the last call, read together at the root call's end: the tip was counted twice, and both credits were labelledGasRefund.balances_after_entrieswalks the batch backwards from the final balances, so eachBalanceChange/BalanceTransferends where the next change of that account starts (AccountDestroyedis followed too). An account with one change per read, which is every case outside Base's0x79path on this branch and onrelease/reth-2.x, gets exactly the same values as before.RootJournalReasons: an account listed several times takes its reasons in list order, one per change, and keeps the last one. revm journals no entry for a balance write that moves nothing, so a payer that is also the beneficiary and gets no refund has its tip labelledGasRefund; the amounts stay right.root_journal_reasons_split_two_credits_of_the_same_accountchecks the old/new values and reasons; it fails with the previous reads. 35 reth-firehose tests pass, no new clippy warnings.After the tag, Base passes
(beneficiary, RewardTransactionFee)after the payer's refund entry, which it already does.