Repository navigation
Merge reth v2.8.0 - #78
Merged
Merged
Conversation
…gmxyz#27529) Co-authored-by: Amp <amp@ampcode.com>
…igmxyz#27585) Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…adigmxyz#27462) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…#27229) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Alexey Shekhirin <github@shekhirin.com> Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Niran Babalola <niran@niran.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…27586) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…gmxyz#27624) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…27482) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…ts (paradigmxyz#27632) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…z#27988) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
…weekly group (paradigmxyz#28014) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Stammler <seb@oplabs.co> Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Brian Picciano <me@mediocregopher.com> Co-authored-by: Brian Picciano <933154+mediocregopher@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
The traced execution path passes no prewarm results to execute_transactions, so every transaction still runs through the Firehose inspector when --engine.prewarm-reuse is set.
sduchesneau
marked this pull request as ready for review
October 21, 2026 17:57
Author
commits description
Nothing else Firehose-specific changed, because no other upstream change touched the tracing path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream reth v2.8.0. revm and alloy-evm are unchanged, so the
v0.39.0-sfevm fork still applies.Firehose review of the new execution features:
--engine.prewarm-reusecommits a prewarm result instead of executing the transaction, which would hide it from the tracer. The traced path (execute_and_trace_block) now passes no prewarm results, andFirehoseEvmConfigkeeps the defaultreuses_prewarm_results() == false, so reuse is off on our binary. The newfirehose_live_tracing_prewarm_reusetest enables reuse on a stockEthEvmConfignode: with reuse wired into the traced path, 5 of 16 transfers went missing from the Firehose block.BalanceTrackerinspector, never the Firehose one.--snap.v2(opt-in snap sync) skips executing blocks below its pivot, so no Firehose blocks exist below it. Documented in the changelog.Tests:
reth-firehose,reth-firehose-tests, and the threefirehose_live_tracing*engine-tree tests pass. Battlefield reth-dev (Amsterdam, battlefield-ethereumffd9260): 94 passing, 8 pending, compare-blocks against RPC matches. Battlefield reth-devnet (builder-playground, pre-Amsterdam): 84 passing, 19 pending (Amsterdam and BNB-only), blocks 1–131 identical to RPC.