Repository navigation
fix: Animate avatars/icons that's using the .webp file format - #144
Conversation
As you may of known, WebP can also be animated and provides some advantages, like having a smaller file sizes over GIF. Though, the point is that WebP can be animated, and so—it should have the same effect as normal GIFs - it having the loop animation than it just being static. Signed-off-by: xanners <xxdr@duck.com>
329082c to
b691290
Compare
|
DCO'd |
|
I wonder if it makes sense here to make a new |
probably, but what other format are there that people uses on a regular meant for this case? |
|
|
It looks like this should close stoatchat/for-web#827. Were you able to test that this fix worked as expected @pparaxan ? |
If you're talking about if I made my own self-hosted instance with the patches and all and see if it works—no, I just use the context available on how the code works and impl the fix as needed. afaik—there was no code related to this in the frontend, only here in the javascript client, in which—the frontend pulls as a Git submodule |
|
It should work anyways because as says in the diff—that function is the one responsible for generating an URL of files. |
I just tried it and it turns out somebody (in-between the time this PR was made and now) just made a fix over the frontend which I think eliminated the need for the so I think if anything—you should just close this PR. |
|
Closing. FYI pparaxan you can choose to close PRs you opened yourself. |
Oh sorry, I just forgor that I made this PR. Should've closed it once I realised that it has been fixed. edit: I don't use GitHub that much. |
|
This isn't fixed. And this change does in fact get the webp's to animate so I'm gonna merge it |
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
|
For future contributions, please ensure you run |
WebP can be animated, and so—it should have the same effect as normal GIFs—having the loop animation than it just being static.