Repository navigation
fix(tui): refresh working status when tools finish - #225
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tool finishes before the next assistant output, the Step working indicator keeps showing
Running...,Reading..., orEditing.... The tool result and spinner are already complete, but the tool-verb hold remains set, so a slow next response looks like a tool that is still running.Release that hold and clear the previous reasoning phase on
tool_execution_end, then refresh the indicator after stopping the completed tool's spinner. Any remaining parallel tool keeps its own active verb; otherwise the indicator returns toWorking...while preserving elapsed time and token counts.This fixes the reproducible status display issue. The separately reported 30–60 second execution delay was not reproduced and is not claimed fixed by this PR.
Validation:
npm run checkpasses../test.shpasses on Node 22.19.0, including the offline build and all workspace test suites (credential-dependent tests are skipped by the isolated runner).