Skip to content

fix: install default resources regardless of CRD maintenance flag - #439

Merged
xeniape merged 1 commit into
mainfrom
fix/create-default-resources
Oct 13, 2026
Merged

xeniape merged 1 commit into
mainfrom
fix/create-default-resources

Conversation

@xeniape

@xeniape xeniape commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes stackabletech/issues#885 for listener-operator. This PR:

If approved, I will apply the same change to the secret-operator

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 12, 2026
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Oct 12, 2026
Comment thread rust/operator-binary/src/main.rs
@xeniape
xeniape requested a review from NickLarsenNZ October 13, 2026 07:18

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 13, 2026
@xeniape

xeniape commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

Thank you!

@xeniape
xeniape added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit d45af97 Oct 13, 2026
13 checks passed
@xeniape
xeniape deleted the fix/create-default-resources branch October 13, 2026 08:02
@xeniape xeniape mentioned this pull request Oct 13, 2026
20 tasks
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

Setting maintenance.customResourceDefinitions.maintain: false stops listener- and secret-operator from creating their default resources

3 participants