[Rushaway]

Summary

Fixes the temp-file and file-descriptor leaks in the TTS commands (!say, !tsay, !dec) and moves gTTS synthesis off the event loop. Scope: the Say, TranslateSay and DECTalk classes in Commands.py, plus a few module-level helpers placed between TranslateSay and DECTalk.

One ownership scheme for TTS temp files

Why: Say.Say and TranslateSay.Say created a NamedTemporaryFile(delete=False) and then called gTTS.write_to_fp(). Any gTTS or HTTP error (rate limit, network down) left the handle open and the file on disk. DECTalk.Say leaked the file when the say binary was missing or communicate() failed.

Fix:

• _write_gtts_file writes inside with temp_file: and removes the file if anything raises.
• _play_tts_file hands the file to the clip's Stop callback only after Play() succeeded. If AudioClip() returns None, Play() returns False, or either of them raises, the file is removed.
• The Stop callback captures only the path string, so no file object or other large object outlives the playback.
• Temp files use the torchlight-tts- prefix (.mp3 for gTTS, .wav for DECtalk), so leftovers are easy to spot.
• TranslateSay.Say now calls super().Say(...) after translating instead of keeping a copy of the synthesis code.

gTTS no longer blocks the event loop

Why: write_to_fp() is a synchronous HTTP call. While it ran, the whole loop was frozen: every playing stream stopped feeding the voice server, and RCON and SourceMod messages queued up.

Fix: gTTS(...) and write_to_fp now run in asyncio.to_thread. The worker thread cannot be interrupted, so if the task is cancelled while it runs, a done-callback removes the file once the thread finishes.

DECTalk hardening

Why: the say exit code was ignored, so a failed synthesis played an empty file. The process was not killed on error or cancellation. _func also set the chat cooldown twice.

Fix:

• A non-zero exit code is treated as a failure.
• If communicate() raises or is cancelled, the process is killed and reaped.
• The temp file is removed on every failure path.
• The duplicate SetPlayerCooldown is gone.

Failures are logged and reported to the player

Why: Say() was started with a bare asyncio.ensure_future, so its exceptions were never logged.

Fix:

• Say._func (also used by TranslateSay) and DECTalk._func now start the coroutine with Utils.FireAndForget(coro, self.logger).
• Synthesis failures are logged and the player gets a private message. gTTS shows TTS failed: <error>, the same text !tsay already used. DECtalk shows a plain TTS failed., because its errors can contain server paths.

Everything else the player sees is unchanged.

Test plan

• ruff check ., ruff format --check ., mypy: no new findings. The only remaining ones are the 3 known baseline errors fixed by CI: Python Linting is red on master since the Python 3.12 bump (ruff UP041, mypy arg-type) #178's PR.
• Local script with stubbed gTTS, AudioManager and subprocess. It counts torchlight-tts-* files in the temp dir before and after each case:
  • write_to_fp raises: no file left, player gets TTS failed: ..., returns 1
  • Slow fake gTTS (0.5 s): a concurrent 20 ms ticker kept ticking (16 ticks), so the loop is not blocked
  • AudioClip() returns None, Play() returns False, AudioClip() raises: no file left
  • Successful play: the file exists until the Stop callback runs, then it is removed. The callback closure holds only a str.
  • Task cancelled during gTTS synthesis: the file is removed once the worker finishes
  • TranslateSay: gTTS error, Play() fails, and success with Stop
  • DECTalk with the binary missing: no file left, player gets TTS failed.
  • DECTalk with a non-zero exit code: no file left, nothing played
  • DECTalk with a hung process that gets cancelled: the process is killed and waited, and no file is left
  • DECTalk success: plays with -af volume=10dB, and the file is removed on Stop
  • DECTalk._func: goes through FireAndForget (an unexpected exception is logged) and sets the cooldown once
• Needs a live server: !say, !tsay, !dec play normally, and nothing stays in /tmp after playback ends or is stopped

No VERSION bump (batch policy, see #177).

Closes #183
Part of #177

🤖 Generated with Claude Code