Repository navigation
fix(ci): pin cosign-installer v4.1.2 and fix a racy admins bulk E2E - #87
Merged
Merged
Conversation
#86 bumped it to `@v4`, but cosign-installer publishes no floating major tag (only v4.0.0, v4.1.x), so the Docker image workflow fails at "Unable to resolve action sigstore/cosign-installer@v4" on every push to main. Pin the latest release. v4 still installs the cosign v2.4.1 this workflow asks for.
"bulk select → assign web group" waited for the response and then
called .json() on it. With no rehash SIDs the page reloads as soon as
admins.bulk resolves, so the body can be gone before Playwright reads
it ("Protocol error (Network.getResponseBody): No resource with given
identifier found"). Fetch the real response in a page.route handler,
keep its body, then fulfill the page with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker image workflow (red on
mainsince #86)#86 bumped
sigstore/cosign-installerto@v4. That repo publishes no floating major tag (onlyv4.0.0,v4.1.0,v4.1.1,v4.1.2), so every push tomainnow fails with:Pinned to
v4.1.2, the latest release. v4 still installs cosign v2.x, and the workflow keepscosign-release: 'v2.4.1'. Every otheruses:ref in.github/workflows/resolves (checked each against the action repo's tags).This workflow only runs on push to
mainand on tags, so this PR can't prove it. The next push tomainwill.Racy E2E: "bulk select → assign web group"
The test waited for the
admins.bulkresponse, then called.json()on it. With no rehash SIDs, the page callslocation.reload()as soon as the action resolves, so the body can be evicted before Playwright reads it:It passes on GitHub-hosted runners but failed twice in a row on NiDE's runner (NiDE-gg/sourcebans-pp#36). The test now fetches the real response inside a
page.routehandler, keeps its body, and fulfills the page with it. The assertions are unchanged.Verification
In the local dev container (
sourcebans_e2e, chromium):--repeat-each=10 --retries=0: 9 of 10 fail with the error above.--repeat-each=5: 30/30 pass (all 6 tests, including the fixed one 5/5).CHANGELOG
2.2.9-srcdslab(2.2.6 / 2.2.7 are taken by #82 / #83).