Skip to content

fix(frontend) :: take browser dependencies from npm - #1456

Open
81reap wants to merge 1 commit into
mainfrom
81reap/npm-1
Open

81reap wants to merge 1 commit into
mainfrom
81reap/npm-1

Conversation

@81reap

@81reap 81reap commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

build.rs downloaded Tabler, ApexCharts, Tom Select and the Tabler icon sprite via CDN on every clean build. This came with its own retry loop and cache under target/.

Now we rely on npm to install 3rd party libs and update /* !include */ markers to point at node_modules instead of a URL. This comes with the benifit that the rust build does not need network anymore, but does require npm ci for a clean build.

This should not be merged alone otherwise it will break the crates.io tarball. The next commit in the stack addresses this.


Stack created with GitHub Stacks CLIGive Feedback 💬

`build.rs` downloaded Tabler, ApexCharts, Tom Select and the Tabler icon sprite via CDN on every clean build. This came with its own retry loop and cache under `target/`.

Now we rely on npm to install 3rd party libs and update `/* !include */` markers to point at `node_modules` instead of a URL. This comes with the benifit that the rust build does not need network anymore, but does require `npm ci` for a clean build.

This should not be merged alone otherwise it will break the crates.io tarball. The next commit in the stack addresses this.
@81reap
81reap added this pull request to stack #1462 September 16, 2026 21:27
@81reap 81reap linked an issue Sep 16, 2026 that may be closed by this pull request
@81reap
81reap requested a review from lovasoa September 16, 2026 21:41

@lovasoa lovasoa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Can you please organize the PRs so that all are small enough to be reviewed, yet none breaks the project?

@81reap

81reap commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator Author

@lovasoa not sure how to do both here. I chose to split up this and #1457 as the diff was getting quite big.

That said, with GitHub stacks, we can review both PRs and merge them together so that project is never in a broken state!

@lovasoa

lovasoa commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

It looks like the next pr contains changes unrelated to what you are doing here.

I think you could make a good no-brainer pr with net negative lines of code by keeping the exact exact same output files, but removing the include comment mechanism, hardcoding the concatenation logic in build.rs and copying from node modules instead of the web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split the build

2 participants