Conversation
`build.rs` downloaded Tabler, ApexCharts, Tom Select and the Tabler icon sprite via CDN on every clean build. This came with its own retry loop and cache under `target/`. Now we rely on npm to install 3rd party libs and update `/* !include */` markers to point at `node_modules` instead of a URL. This comes with the benifit that the rust build does not need network anymore, but does require `npm ci` for a clean build. This should not be merged alone otherwise it will break the crates.io tarball. The next commit in the stack addresses this.
lovasoa
requested changes
Sep 16, 2026
lovasoa
left a comment
Collaborator
There was a problem hiding this comment.
Hi! Can you please organize the PRs so that all are small enough to be reviewed, yet none breaks the project?
Collaborator
Author
Collaborator
|
It looks like the next pr contains changes unrelated to what you are doing here. I think you could make a good no-brainer pr with net negative lines of code by keeping the exact exact same output files, but removing the include comment mechanism, hardcoding the concatenation logic in build.rs and copying from node modules instead of the web. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.rsdownloaded Tabler, ApexCharts, Tom Select and the Tabler icon sprite via CDN on every clean build. This came with its own retry loop and cache undertarget/.Now we rely on npm to install 3rd party libs and update
/* !include */markers to point atnode_modulesinstead of a URL. This comes with the benifit that the rust build does not need network anymore, but does requirenpm cifor a clean build.This should not be merged alone otherwise it will break the crates.io tarball. The next commit in the stack addresses this.
Stack created with GitHub Stacks CLI • Give Feedback 💬