fix(big_number) :: preserve color and spacing - #1452
Merged
Merged
Conversation
lovasoa
marked this pull request as ready for review
September 14, 2026 08:27
kryskool
approved these changes
Sep 14, 2026
81reap
approved these changes
Sep 14, 2026
Comment on lines
+7
to
+9
| await page.locator("html").evaluate((html, selectedTheme) => { | ||
| html.dataset.bsTheme = selectedTheme; | ||
| }, theme); |
Collaborator
There was a problem hiding this comment.
we set theme on body not html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tabler 1.5 stopped headings from inheriting the
bg-*-ltforeground and increased default card vertical padding from1remto1.25rem. This PR makes the big-number value color explicit, keeps linked values the same color, and restores compact spacing with a component-scoped variable.This went unnoticed because the template did not change, documentation renders only the current behavior, and no browser test covered computed big-number styles. The new Playwright fixture checks linked and unlinked values in light and dark themes without pinning palette RGB values.
I audited the other
bg-*-lttemplate uses: timeline icons still inherit correctly, table row color is documented as background-only, and the Tabler 1.5 modal regression was already fixed separately.Screenshots
Same SQL and 900x900 viewport in each image; light theme is left, dark theme is right.
v0.46.1
v0.46.2
This PR
Tests
npm testnpx playwright test fixtures/big-number/test.ts --project=fixtures --reporter=lineCloses #1451