fix(chart) :: group points into series without Object.prototype - #1449
Merged
Merged
Conversation
81reap
marked this pull request as ready for review
September 12, 2026 21:19
Collaborator
|
I agree the generated code is cleaner, but I'm not sure I understand the bug. Is there a real bug ? If the only way to reproduce the "bug" is with somthing like SELECT 'chart' AS component, 'constructor' AS type; -- constructor is not a valid chart type, this is documented
WITH points(series, x, y, color) AS (VALUES ('A', 'Q2', 2, 'toString')) SELECT * FROM points; -- toString is not a valid color, documented toothen I don't think this is a bug at all. You can rename it to a refactor or a code cleanup, and not mention it in the changelog at all. |
lovasoa
requested changes
Sep 12, 2026
Points were grouped in a plain object keyed by the `series` value. A series named `toString` or `constructor` threw, rendering nothing. Numeric series names were enumerated in ascending order ahead of text ones rather than keeping the order the rows came in.
81reap
force-pushed
the
81reap/chart-prototype-lookup
branch
from
September 13, 2026 01:10
44309cd to
80aa3ab
Compare
Collaborator
Author
|
This was discovered as a side effect of #1448 but it didn't make sense to belong in that stack. Your right tho that this PR is doing too much and not all of this is an SQLPage issue. I have upstreamed apexcharts/apexcharts.js#5308 and apexcharts/apexcharts.js#5309 as well as updated this PR to focus only on the bug in SQLPage as well as updated the examples to be more clear. |
81reap
changed the title
Object.prototypeObject.prototype
Collaborator
|
Good job! |
lovasoa
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points were grouped in a plain object keyed by the
seriesvalue. A series namedtoStringorconstructorthrew, rendering nothing. Numeric series names were enumerated in ascending order ahead of text ones rather than keeping the order the rows came in.