Repository navigation
fix(dev-1687): bump vitest to 4.1.11 - #56
Open
spur-vuln-author[bot] wants to merge 1 commit into
Open
spur-vuln-author[bot] wants to merge 1 commit into
spur-vuln-author[bot] wants to merge 1 commit into
Conversation
|
high-scrutiny-major-bump: this PR is flagged high-scrutiny: major-bump in its footer (advisory GHSA-82fw-gwwq-j7x9 / GHSA-5xrq-8626-4rwp, package vitest, pnpm-lock.yaml). Per Gate 1 of the review contract, a major-bump flag is unconditionally escalated regardless of CI state or diff cleanliness — this decision belongs to a human. Not merged. A human must review this. This reviewer will not act on this PR again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dependabot opened #55 bumping
vitestfrom 3.2.6 to 4.1.11 (a major version bump) to resolve GHSA-82fw-gwwq-j7x9 (vitest /@vitest/mocker< 4.1.11, medium). The same manifest also carries GHSA-5xrq-8626-4rwp (vitest < 3.2.6, critical) against thispnpm-lock.yamlscope, tracked at DEV-1687.Because this is a major-version bump, it is not eligible for direct
merge-prunder the remediation policy regardless of CI outcome — it must be replayed onto a compliant branch/commit-message and handed tospur-vuln-reviewfor mandatory human sign-off before merge. This PR mechanically replays #55's exact diff (no adaptation code) ontofix/dev-1687.@vitest/mocker(GHSA-82fw-gwwq-j7x9, tracked at DEV-1697) is vitest's own dependency and is bumped to 4.1.11 in this samepnpm-lock.yamldiff as part of this same change.Test evidence
CI ran on the original Dependabot PR #55; this PR's diff is byte-identical to #55's (
package.json+pnpm-lock.yaml), replayed viagit applywith no manual edits. Companion-file scan (companion-scan.sh pnpm-lock.yaml 3.2.6) found no stale companion files (Dockerfiles,.nvmrc, CI workflow pins, etc.) referencing the old version.Note:
pnpmis not available in the remediation runner's sandbox, so the lockfile in this PR is exactly Dependabot's own regenerated content — it was not (and could not be) regenerated locally.Risk
Medium — major version bump of a devDependency (test runner only, not shipped in any package's runtime output).
spur-vuln-reviewshould verify CI passes on this replayed PR before any merge decision; this PR must not be self-merged regardless of outcome (high-scrutiny: major-bump).