Repository navigation
Conversation
Extend upstream currency_scale (springfall2008#6156) with heuristic scaling, precision, price comparisons, money-specific configuration UI steps, and Python/C++ parity. Keep incoming prices, stored values, and defaults unchanged. Use native kernel ABI 13/parity 24 for an explicit currency scale field. Exclude unrelated SolaX service-power changes from springfall2008#5373. Based on upstream main 044e0ab (2026-11-15). CI rebuilds and validates all platform kernel binaries before this PR can be considered merge-ready.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends upstream
currency_scaleintroduced by #6156 with a consistent calibration of built-in monetary heuristics across Predbat's planner, simulation, and UI. This is not an FX conversion: all input tariffs and explicitly configured or saved values remain in local minor units (e.g., haléř / haléř per kWh).What changes
currency_scale.currency_scale: 1compatible with upstream behavior; exercise scale 1, 8.5 and 29.Scope
mainat044e0ab2(2026-11-15).Validation
Validation on 2026-11-16: fork PR-branch workflow run #43814027820 passed: Python syntax, currency configuration/calibration, debug-plan, kernel parity, manual SoC, metric and execute tests, 6-target Zig kernel cross-build, x86_64 binary verification, and committing all rebuilt ABI 13 binaries to the PR branch. An independent manual validation run #43814051315 additionally passed the upstream quick regression suite, all targeted tests, cross-build and parity; its only failed step was a redundant binary push rejected because the first run had already updated the PR branch. The auxiliary runner has been changed to validation-only to prevent competing writes. Upstream's code-quality workflow still shows
action_required, awaiting maintainer action; this PR remains draft pending upstream review/checks. It has not been deployed to Home Assistant.See
docs/currency-scale-audit.mdfor detailed behavior, tradeoffs and migration notes.Related: #6156, #6155, #3683.