Repository navigation
docs(debug-journal): fold the queue slice and correct the Solcast, Hanchu and plan-card entries - #6219
Draft
springfall2008 wants to merge 1 commit into
Draft
docs(debug-journal): fold the queue slice and correct the Solcast, Hanchu and plan-card entries#6219springfall2008 wants to merge 1 commit into
springfall2008 wants to merge 1 commit into
Conversation
…nchu and plan-card entries Fold 15 queued candidates (all verified against main): the Solcast state-cache band compounding and what a Replay-input PV line really logs, the Hanchu write-clamp vs planner-limit split, the plan-card's two SoC renderers, the Climate Scheduler service contract, the component state_class inventory, the Marketplace rename, and the PR-review traps. Drop #6049's retracted fetched-data theory. Also consolidate the largest areas (Octopus, Startup, Plan charging, Tests, Web, Teslemetry, Solis, GE Cloud, Sunsynk/DEYE, Car charging, Component health, Versions/logs, Replays, Inverter control) and retire fixed-bug entries older than six weeks. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is opened and written by the automated triage bot (
/journal-update). Every claim below was re-checked againstorigin/mainat044e0ab2before folding.Took the first 15 candidates in filename order from the queue (
6034…6055). 108 candidates remain queued for later slices.Per candidate
#6034 — PR-review traps. Folded two under Reviewing PRs: judge a PR's
COMPONENT_LIST/config.pyscaffolding againstorigin/main(main holds"module.ClassName"strings resolved byload_component_class(), pinned by the quick-suiteevery_component_class_importstest), and a test file importingpytestbreaks the whole suite at import time because theTEST_REGISTRYloop imports every module andpytestis not a dependency. Dropped the third item (_token/_key-suffixed config item not marked"secret": Trueis not a leak) — already covered by theis_secret_key()substring bullet under Debug yaml can contain real secrets.#6037 — plan-card SOC symbols. Folded, merged with #6039 into one entry: ⚠ is the weather-alert keep, ✎ the manual SoC target, ⬇ the manual SoC max. The docs gap it reported is closed — #6039 merged 2026-11-08 (
d2d7c6bf) — so the entry records the symbol meanings and the renderer divergence, not the missing legend.#6038 — Predheat
domain=asymmetry. Sharpened the existing Predheat bullet rather than adding a second: the domain keyword belongs to the outer read only, and the nestednext_volume_tempfallback must keep none because it is the read half of the persistence round trip. Rewritten aroundget_temperature_arg()— the read moved into that helper, so the candidate's literal line no longer exists.#6039 — two plan renderers. Folded into the same entry, corrected against main: the HTML plan now marks ⬇ by presence (
minute in manual_soc_max_keep), because the candidate's cleanup commit landed with the merge; ⚠ and ✎ still gate on> 0. The web card still marks by membership (0-valued entries included) and appends ℮ plus a second ⬇;execute.py's[Manual SoC Max]suffix still gates on> 0. Verified by readingoutput.py,web_helper.py,web.pyandexecute.py.#6040 — HACS becomes Marketplace in HA 2026.11. Folded one short bullet under Platform, web and updates: HACS cannot be installed on 2026.11+, is removed on upgrade, and AppDaemon apps stop being managed. The docs now cover both paths (#6041 merged 2026-11-08), so the entry is for diagnosing the report, not for a docs gap.
#6042 — Climate Scheduler contract. Folded a compact bullet under Predheat (service names,
schedule_modevalues, the exactworkdays/use_workday_integrationsettings keys,workday/check_date's field and response shape, the hardcodedbinary_sensor.workday_sensor). PR merged 2026-11-15 (b296ffe4), so this describes merged code. Dropped the pytzlocalize()walkthrough and the unrun probe narrative.#6044 — Hanchu write clamp vs planner limits. Rewrote an existing entry. The "Power limits (PR #5684…)" bullet read as if
hanchu_battery_rate_max/hanchu_inverter_limitwere the top of the priority for the write clamp. Re-read on main:ranges_for()builds theCHG_PWR_LMT/DSCHG_PWR_LMTclamp as max(menu range, highest value seen held), capped by theHANCHU_MODELSrating, and honours no user override; the overrides only set the planner'sbattery_rate_max/inverter_limit. Now two explicitly labelled layers.#6045 — daily counters and
state_class. Folded a Sensors, history and load data bullet. Inventory re-checked on main: Deye istotal_increasingsince #6053; the gateway and GE Cloud*_todayattribute tables still ship plaintotalwith nolast_reset.#6046 — teslemetry reserve band. Almost all of this was already in the journal from the earlier fold of #6046/#6050. Added one missing trap: the reserve reaching the component during a freeze is floor(SoC), not SoC+1 (
reserve_above_soc_charges_from_grid+hold_reserve_percent()), so a fix or test modelled on "SoC+1" has the wrong input. Dropped the two-docstring disagreement as already covered by the existing "snap direction unsettled" sentence.#6047 — Sigenergy rates outside windows. Folded a Sigenergy bullet: outside a window the rate entities are mode-selection signals only, the branch ladder is export window → charge window →
charge_rate_w == 0→export_rate_w == 0→ eco, and the balancer's holds are written asintent[...]inutils.py, not inexecute.py. Re-verified on main after #6047 merged (6ad5e9d5).#6048 — IOG BOOST/bump-charge pricing. Dropped: the pricing bug was fixed by #6051 (merged 2026-11-09), and its other durable fact — the negative
charge_in_kwh/ keep theabs()— is already in the Octopus notes. Its one remaining trap, the duplicated billing predicate, is folded from #6051 below.#6049 (escalation in the fetched data). Dropped as retracted. The
Replay input: PV forecast changedrows logpv_forecast_minute/10/90, the post-calibration planner series (confirmed infetch.py'slog_replay_pv_forecast), so they cannot prove what the integration served. The real mechanism is #6055's state-cache aliasing. Recording this as correct would have put a wrong causal claim in front of the next reporter.#6049 (replay rows post-calibration). Folded into Solcast: what those log rows really are, that a ~30-minute step pattern is Predbat's own
plan_interval_minutesread cadence rather than the provider's poll, and thatdetailedForecastis kW per slot (sum = 2× the kWh total on 30-minute slots).#6051 — tariff-billing predicate duplication. Folded an Octopus bullet:
dispatch_billed_off_peak()andload_octopus_slots()'stariff_rate_slotencode the same source set independently, and nothing fails loudly when they drift.#6055 — HA state-cache attributes by reference. Folded a Solcast bullet as the root cause of the P90 compounding, with the fix: #6055 merged 2026-11-09 (
5cc7c61f),fetch_pv_forecast()now copies the entries, and the general rule (copy aget_state()attribute container before mutating it when the same state will be fetched again) is kept because it applies to other components.Existing entries corrected
ranges_for()on main.b296ffe4): the component now makes three more read-onlyreturn_responsecalls, so "the only outbound call isweather/get_forecasts" was no longer true.volume_temp— invalidated by the same PR: the read is now insideget_temperature_arg(); kept the mechanism and the nested-fallback trap, rewrote the pointer.Consolidation
The file was 226KB on entry, above the ~150KB guide. This PR consolidates the largest areas — Octopus, Startup/config, Plan charging, Tests/kernel, Web/MCP, Teslemetry, Solis, GE Cloud, Sunsynk/DEYE, Car charging, Component health, Versions/logs, Replays/dumps, Inverter control, Replays, GitHub/tooling, Predheat — by merging overlapping bullets and dropping repeated caveats. It also retires fixed-bug entries older than about six weeks: the pre-#5377 Sigenergy command-shape note, the #5464 docs-freeze story (keeping only the rated-power sensor names), and the pre-#5256 Solis Modbus sentence.
Net size is flat: about 9KB of verified material went in and about 9KB of older wording came out (226,152 → 226,590 bytes). Getting under 150KB would mean dropping roughly a third of the remaining entries, which are unique mechanisms rather than repetition, so I stopped short of that. A follow-up decision worth taking: whether the "older-log signature" class (entries whose only remaining value is dating a pre-fix log) can be dropped wholesale — that is the largest remaining block that is not a live trap.
./run_pre_commitpasses (hooks and the quick suite, 7 slow tests skipped). New word added to the cspell workspace dictionary:hacsfiles.