Skip to content

docs(debug-journal): fold the 2026-10-29..11-04 queue slice (13 of 15 candidates) - #5993

Merged
springfall2008 merged 1 commit into
mainfrom
bot/debug-journal-2026-11-06
Nov 6, 2026
Merged

springfall2008 merged 1 commit into
mainfrom
bot/debug-journal-2026-11-06

Conversation

@springfall2008

Copy link
Copy Markdown
Owner

Automated journal update from the triage bot — folds the next queue slice into tools/debug-journal.md after re-verifying each candidate against current main. Docs-only change; the quality gate (coverage/run_pre_commit) is green (all hooks passed, quick suite: all tests passed). No existing entries needed correcting this time — the journal was compacted yesterday (#5988) and every claim it makes about main held at ff6eccf.

Slice: the first 15 candidates in filename sort order (5556-… then 5834-…–5849-…). 91 candidates remain queued.

Per candidate:

  • 5556 (SolisCloud outage codes) — folded one bullet into the Solis row: B0072/B0673 fall through SOLIS_API_CODES_NO_RETRY and get no datalogger cooldown, and B0673 carries B0600's message text so classification must key on the code. Verified against main by reading the three code tables in solis.py (no B0072/B0673 hits repo-wide). Two of the candidate's other points were dropped as per-issue: the feat(solis): write a parallel master's slot current for the whole group (#5556) #5909 diff detail (the Solis row already documents the parallel-pair gap and PR feat(solis): write a parallel master's slot current for the whole group (#5556) #5909) and the "name which commits a field test covered" note (covered by the version-drift trap bullet).
  • 5834 (Solis FB00 hold with no energy_control_switch) — folded into the Solis Modbus row: with the switch unset, write_solis_energy_control() writes nothing and warn_missing fires only on a real charge cycle, so freeze/hold cycles degrade silently; an S6-style separate work-mode select is not a valid target. Verified on main: adjust_charge_immediate() still writes with warn_missing=(target_soc > 0 and not freeze).
  • 5835 (balancer reserve-unit conflation) — folded as a new small area, "Balancer (utils.py balance_inverters())": check the snapshot builder first, the three similarly-named reserve attributes, adjust_reserve() not refreshing the _current attributes (re-verified on main today), and the fixture trap (the execute-path fixture still stores a percent into the kWh field, seen again on main).
  • 5836 (dummy-reserve kWh echo) — dropped as overtaken: since it was written, PR fix(balance): pass the inverter reserve to the balancer in percent (#5835) #5836 (snapshot now reads reserve_percent_current) and PR fix(inverter): seed the dummy reserve of a register-less inverter in percent, not kWh (#5850) #5870 (register-less dummy reserve seeded in percent, not kWh) both merged, so the kWh-echo mechanism no longer describes main. Its still-true kernel lives in the new Balancer area via the Inverter balancing compares SoC percent against the reserve in kWh #5835 fold.
  • 5837 (EntityHistory prune anchor) — folded into "History fetch / memory": since PR fix(history): keep the state in force at the prune cutoff, so a rarely-changing sensor keeps its history #5837 the prune keeps a re-stamped anchor record at the cutoff, so the cached oldest record can be an artificially-stamped one; the merge-contradiction risk stays marked suspected (unverified, as in the candidate).
  • 5839 (manual-API docs drift) — folded into "Manual override selects": the allowlist is the whole gate and inverter_limit_charge_dc is in CONFIG_API_OVERRIDE but still missing from docs/manual-api.md's list — re-verified on main today (docs list has inverter_limit/_charge/_discharge/_export only).
  • 5840 (Fox unsupported-setting log level) — folded into the Fox row's errno bullet: since PR fix(fox): stop logging an expected unsupported setting as a warning #5840 (2026-10-30) the three unsupported-setting lines log at Info; a Warn form in an attached log just dates it to pre-fix(fox): stop logging an expected unsupported setting as a warning #5840. Verified the Info forms on main.
  • 5841 (prefix-vs-substring log classification) — folded as a new trap bullet under "Versions, logs and attachments": the console gate is prefix (hass.py), the web log tab is substring (classify_log_line()), plus the de-noise technique. Verified both classifiers and PR fix(inverter): warn once, not every cycle, while battery_scaling keeps reading invalid #5841's merged shape.
  • 5842 (WhatIf kWp row goes stale on merge) — dropped: job already done. PR fix(annual): show the kWp of a solar array given as a number of panels #5842 merged (f889189) and the journal's WhatIf bullet was already reworded to "fixed in PR fix(annual): show the kWp of a solar array given as a number of panels #5842 (2026-10-29). Still live: _arg() passes no required_unit" at the 5 Nov compaction.
  • 5843 (Kraken window / now_utc naming) — the naming trap itself was already covered by the journal's clocks bullet; folded only what was missing: a Kraken-row bullet on the rate-window bounds (REST = true local-midnight instants since PR fix(kraken): bound the REST rates request to the window Predbat reads back #5843, GraphQL fallback still true UTC midnight) and the minute_data() ±(forecast_days+1)-days-either-side read-back bound (verified on main), plus a clause in the clocks bullet on setting the clock after construction (ComponentBase's midnight_utc is a property). The candidate's correction of an old triage comment was dropped as per-issue.
  • 5844 (Sigenergy onboard_status vocabulary) — folded into the Sigenergy row: open string vocabulary, published verbatim, cached in Storage, consumed by predbat-saas so the SaaS UI lags, and failed-run statuses stay in memory until the poll-cadence save. Verified the publish path and cache keys on main.
  • 5846 (Huawei DC/AC charge split) — folded as a new area, "Huawei (no code — templates/huawei.yaml only)": inverter_limit_charge_dc is model-only, execution rewrites the wired charge_rate to the AC cap every idle cycle, the huawei_solar "maximum charging power" register is the battery's overall ceiling not a grid-only cap, and the chat-agent trap. Verified: no huawei.py, the template wiring, the docs sentence, and that no execution path consumes battery_rate_max_charge_dc (prediction only).
  • 5847 (MCP OAuth shared secret) — folded into the web/MCP row as confirmed-on-main (2026-10-29) and unfixed at 2026-11-06: one mcp_secret behind four mechanisms, JWT key derived from it, scope never enforced; defaults (enable off, predbat_mcp_secret, binds 0.0.0.0) re-verified on main. The candidate's line numbers were stripped per the journal's house rules.
  • 5848 (Kraken wiring car 0, is_charger: false) — folded into the shared charger-control row: the components re-point octopus_intelligent_slot with a plain set_arg regardless of apps.yaml, is_charger: false leaves the charger alone and skips plan_car_charging() (both by design); umbrella Octopus Intelligent: correlate car chargers with Octopus devices instead of assuming car 0 #5726. Verified the set_arg site, the is_charger veto and the plan-skip comment on main. Dropped: the reporter-dump-only claim about write cadence (not independently verifiable here).
  • 5849 (discovery info strings-only) — folded as a new area, "Discovery catalogue (coordinator.py)": the typed container map, the dropped-value warn signature, and the per-branch round-trip-test need. The stub part of the candidate is fixed on main — the marker now lives in flags: ["stub"] (landed with the reporter features) — so the entry keeps only the still-true container mechanics.

No existing entry was corrected or removed: HEAD is yesterday's journal compaction (#5988), no code merges have landed since, and each of the candidates' conflicts with the journal resolved in favour of the merged fixes above rather than a stale journal line.

… candidates)

Add balancer, Huawei-template and discovery-catalogue notes; the rest are
folded into existing rows (Solis, Solis Modbus, Fox, Kraken, Sigenergy,
web MCP, charger control, manual-API, history cache) and two trap bullets.
Two candidates dropped as overtaken by merged fixes (#5836/#5870, #5842).

Co-Authored-By: Claude Code <noreply@anthropic.com>
@springfall2008
springfall2008 marked this pull request as ready for review November 6, 2026 16:29
@springfall2008
springfall2008 enabled auto-merge (squash) November 6, 2026 16:29
@github-actions github-actions Bot added the BOT_REVIEW Trigger an autotriage label Nov 6, 2026
@springfall2008
springfall2008 merged commit 1fe2e73 into main Nov 6, 2026
8 checks passed
@springfall2008
springfall2008 deleted the bot/debug-journal-2026-11-06 branch November 6, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BOT_REVIEW Trigger an autotriage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant