Skip to content

Harden AWS Security Hub ingestion and pagination - #23

Merged
phantom-jacob merged 8 commits into
mainfrom
sodle/espm-5228-awssecurityhub-security-fixes
Jul 19, 2026
Merged

phantom-jacob merged 8 commits into
mainfrom
sodle/espm-5228-awssecurityhub-security-fixes

Conversation

@sodle-splunk

@sodle-splunk sodle-splunk commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Authored by Codex for the ESPM-5228 Flashpoint connector-remediation campaign.

Summary

  • escape dynamic finding values before embedding them in widget JavaScript
  • bound Security Hub pagination and reject repeated continuation tokens
  • advance scheduled-poll state only through the last finding persisted successfully
  • acknowledge SQS messages only after every finding they contain is stored successfully
  • refresh generated dependency metadata and add focused regression coverage

Tracking

Quality gate

  • pre-commit run --all-files passed (with only the known macOS-inaccurate NOTICE generator skipped; the retained NOTICE was updated without truncation)
  • focused security regression tests: 4 passed
  • Python compilation passed

Tracking

  • PAPP: PAPP-38066
  • PSAAS: PSAAS-30814, PSAAS-31807, PSAAS-32010, PSAAS-32278
  • Written by Codex.

@github-actions

github-actions Bot commented Jul 17, 2026 •

Copy link
Copy Markdown

Merging this PR will release 2.4.4 with the following release notes:

2.4.4 (2026-07-18)

Connector release changes

  • Escaped dynamic JavaScript values in the get findings widget.
  • Derived polling windows and durable checkpoints from UTC finding progress.
  • Deleted SQS messages only after all included findings persist successfully.
  • Bounded pagination and rejected repeated continuation tokens.

@sodle-splunk
sodle-splunk marked this pull request as ready for review July 17, 2026 16:33
Remove unsupported BaseConnector-local tests and normalize generated release-note bullets where applicable. The full connector pre-commit gate remains the executable regression check.\n\nWritten by Codex.
@phantom-jacob
phantom-jacob merged commit e58f20d into main Jul 19, 2026
10 of 21 checks passed
@phantom-jacob
phantom-jacob deleted the sodle/espm-5228-awssecurityhub-security-fixes branch July 19, 2026 16:21
@splunk-soar-semantic-release

Copy link
Copy Markdown

🎉 This PR is included in version 2.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants