Repository navigation
Force the Protobuf 4.36.2 runtime in first-model-with-framework - #1
Merged
Merged
Conversation
The Validation docs build runs this example with the plugin versions of the main Validation build, which now generate Protobuf gencode 4.36.0. The forced 4.35.0 runtime is older, so every test of this project failed with `ProtobufRuntimeVersionException`, failing the `Build embedded code` check of the Validation repository since September 9. Force 4.36.2, the version the main Validation build pins. A runtime may be newer than the gencode, so the plugin versions committed here still work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Point to `Protobuf.version` in the `buildSrc` of the main Validation build, and say that the force also suits the older gencode of the plugin versions committed here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused runtime update addresses the reported incompatibility, with passing verification reported for both plugin configurations and no blocking findings.
No open issues 🎉
What changed in this PR
Updates the framework example’s Protobuf runtime to support code generated by Validation’s docs build.
Changes:
- Raises the forced runtime from
4.35.0to4.36.2, leaving plugin versions unchanged. - Explains compatibility with both committed and docs-rewritten plugin versions.
| File | Description |
|---|---|
first-model-with-framework/build.gradle.kts |
Updates the runtime pin and clarifies its compatibility rationale. |
Review effort: Balanced
alexander-yevsyukov
added a commit
to SpineEventEngine/validation
that referenced
this pull request
Oct 17, 2026
`first-model-with-framework` forced the 4.35.0 runtime, older than the 4.36.0 gencode of the plugins the docs build runs it with, so the required `Build embedded code` check has failed since September 9. The examples now force 4.36.2 (spine-examples/hello-validation#1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Build embedded codecheck of SpineEventEngine/validation, which is required on itsmaster, has been failing since September 9. It also blocks the dependency-refresh PR SpineEventEngine/validation#332.The check runs
./gradlew :docs:buildAllinvalidation. That task rewrites the plugin versions in this repository's build files to match the main Validation build,io.spine.validation2.0.0-SNAPSHOT.465andio.spine.core-jvm2.0.0-SNAPSHOT.097, then builds the examples. Those plugins generate Protobuf gencode4.36.0.first-model-with-frameworkforced the runtime down to4.35.0, so all 12 of its tests failed with:Change
first-model-with-framework/build.gradle.ktsforces the Protobuf runtime to4.36.2, theProtobuf.versionof the main Validation build. A runtime may be newer than the gencode it loads, so the plugin versions committed here (.462/.080), which generate older gencode, keep working. The comment above the force now explains both cases.The plugin versions here are unchanged on purpose: the Validation docs build rewrites them, and
.465is not published until validation#332 merges.Verification
validation,./gradlew :docs:buildExampleswith the rewritten plugin versions:first-model12/12 andfirst-model-with-framework12/12 tests pass. Before the change,first-model-with-frameworkfailed 12/12../gradlew buildAllwith the committed plugin versions: both projects 12/12.pluginsblock, which is unchanged.After this merges, validation#332 bumps its
docs/_examplessubmodule to the merge commit.🤖 Generated with Claude Code