Skip to content

Force the Protobuf 4.36.2 runtime in first-model-with-framework - #1

Merged
alexander-yevsyukov merged 2 commits into
masterfrom
align-protobuf-runtime
Oct 19, 2026
Merged

alexander-yevsyukov merged 2 commits into
masterfrom
align-protobuf-runtime

Conversation

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

Problem

The Build embedded code check of SpineEventEngine/validation, which is required on its master, has been failing since September 9. It also blocks the dependency-refresh PR SpineEventEngine/validation#332.

The check runs ./gradlew :docs:buildAll in validation. That task rewrites the plugin versions in this repository's build files to match the main Validation build, io.spine.validation 2.0.0-SNAPSHOT.465 and io.spine.core-jvm 2.0.0-SNAPSHOT.097, then builds the examples. Those plugins generate Protobuf gencode 4.36.0. first-model-with-framework forced the runtime down to 4.35.0, so all 12 of its tests failed with:

ProtobufRuntimeVersionException: Detected incompatible Protobuf Gencode/Runtime versions when loading BankCard: gencode 4.36.0, runtime 4.35.0. Runtime version cannot be older than the linked gencode version.

Change

first-model-with-framework/build.gradle.kts forces the Protobuf runtime to 4.36.2, the Protobuf.version of the main Validation build. A runtime may be newer than the gencode it loads, so the plugin versions committed here (.462/.080), which generate older gencode, keep working. The comment above the force now explains both cases.

The plugin versions here are unchanged on purpose: the Validation docs build rewrites them, and .465 is not published until validation#332 merges.

Verification

  • In validation, ./gradlew :docs:buildExamples with the rewritten plugin versions: first-model 12/12 and first-model-with-framework 12/12 tests pass. Before the change, first-model-with-framework failed 12/12.
  • Here, ./gradlew buildAll with the committed plugin versions: both projects 12/12.
  • The docs page that embeds this file takes only its plugins block, which is unchanged.

After this merges, validation#332 bumps its docs/_examples submodule to the merge commit.

🤖 Generated with Claude Code

alexander-yevsyukov and others added 2 commits October 17, 2026 02:27
The Validation docs build runs this example with the plugin versions of
the main Validation build, which now generate Protobuf gencode 4.36.0.
The forced 4.35.0 runtime is older, so every test of this project failed
with `ProtobufRuntimeVersionException`, failing the `Build embedded code`
check of the Validation repository since September 9.

Force 4.36.2, the version the main Validation build pins. A runtime may be
newer than the gencode, so the plugin versions committed here still work.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Point to `Protobuf.version` in the `buildSrc` of the main Validation build, and say that the force also suits the older gencode of the plugin versions committed here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alexander-yevsyukov
alexander-yevsyukov requested a balanced review from Copilot October 17, 2026 01:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T01:31:36.928209Z 93d152f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused runtime update addresses the reported incompatibility, with passing verification reported for both plugin configurations and no blocking findings.

No open issues 🎉

What changed in this PR

Updates the framework example’s Protobuf runtime to support code generated by Validation’s docs build.

Changes:

  • Raises the forced runtime from 4.35.0 to 4.36.2, leaving plugin versions unchanged.
  • Explains compatibility with both committed and docs-rewritten plugin versions.
File Description
first-model-with-framework/​build.gradle.kts Updates the runtime pin and clarifies its compatibility rationale.

Review effort: Balanced

alexander-yevsyukov added a commit to SpineEventEngine/validation that referenced this pull request Oct 17, 2026
`first-model-with-framework` forced the 4.35.0 runtime, older than the
4.36.0 gencode of the plugins the docs build runs it with, so the required
`Build embedded code` check has failed since September 9. The examples now
force 4.36.2 (spine-examples/hello-validation#1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alexander-yevsyukov alexander-yevsyukov self-assigned this Oct 19, 2026
@alexander-yevsyukov
alexander-yevsyukov merged commit f0c22bc into master Oct 19, 2026
1 check passed
@alexander-yevsyukov
alexander-yevsyukov deleted the align-protobuf-runtime branch October 19, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants